You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/28 13:35:53 UTC
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request
#1622: we should insert alert in DB once ,
and trigger this type of alert 3 times
Technoboy- opened a new pull request #1622: we should insert alert in DB once , and trigger this type of alert 3 times
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1622:
we should insert alert in DB once , and trigger this type of alert 3 times
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622#issuecomment-569418173
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=h1) Report
> Merging [#1622](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/dce7441bea67835be7ff4bd1783d1b4f3e137a9d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1622 +/- ##
========================================
+ Coverage 8.1% 8.1% +<.01%
========================================
Files 282 282
Lines 13790 13787 -3
Branches 2203 2200 -3
========================================
Hits 1118 1118
+ Misses 12588 12585 -3
Partials 84 84
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/server/zk/ZKMasterClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLTWFzdGVyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=footer). Last update [dce7441...cfd3266](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1622:
we should insert alert in DB once , and trigger this type of alert 3 times
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1622: we should insert alert in DB once , and trigger this type of alert 3 times
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1622:
we should insert alert in DB once , and trigger this type of alert 3 times
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622#issuecomment-569467167
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1622:
we should insert alert in DB once , and trigger this type of alert 3 times
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622#issuecomment-569467062
> node down is very serious，so intentionally added retries
Yes, it is .
But we should insert alert info in DB for only once , and we should also define alert level or alert type to notice user more times instead. In this way , we can decrease DB pressure .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services