[GitHub] [flink-kubernetes-operator] bgeng777 commented on a diff in pull request #204: [Flink 27329] Add default value of replica of JM pod and not declare it in example yamls

[GitBox <gi...@apache.org>]

bgeng777 commented on code in PR #204:
URL: https://github.com/apache/flink-kubernetes-operator/pull/204#discussion_r870931220


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/FlinkDeploymentSpec.java:
##########
@@ -45,7 +45,7 @@ public class FlinkDeploymentSpec extends AbstractFlinkSpec {
     private String imagePullPolicy;
 
     /** Kubernetes service used by the Flink deployment. */
-    private String serviceAccount;
+    private String serviceAccount = "flink";

Review Comment:
   thanks for the suggestion. It makes sense to me to add validation check so that serviceAccount will be a required field.
   For users who use helm and set a different serviceAccount, they are supposed to be aware of using correct service account.
   For users who use helm and use the default serviceAccount, we may add some comments in examples or detailed validation error info to alert users to set the correct serviceAccount(i.e. `flink`).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org