[lucene-solr] branch branch_8x updated: SOLR-14635: disable test that has silly concurrency assumptions

[ho...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hossman pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/branch_8x by this push:
     new da975fc  SOLR-14635: disable test that has silly concurrency assumptions
da975fc is described below

commit da975fc46cffca332855860b015e8cc52dc5ed66
Author: Chris Hostetter <ho...@apache.org>
AuthorDate: Thu Jul 9 18:23:22 2020 -0700

    SOLR-14635: disable test that has silly concurrency assumptions
    
    (cherry picked from commit 5a422db60e26e8d5488edb0d575cb86a60023a5d)
---
 .../test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java b/solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java
index ef28b8c..aab2b77 100644
--- a/solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java
@@ -30,6 +30,13 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.junit.BeforeClass;
 
+/**
+ * This test is currently flawed because it only ensures the 'test-*' threads don't exit before the asserts,
+ * it doesn't adequately ensure they 'start' before the asserts.
+ * Fixing the ownershipt should be possible using latches, but fixing the '*-blocked' threads may not be possible
+ * w/o polling
+ */
+@SolrTestCaseJ4.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-14635")
 public class ThreadDumpHandlerTest extends SolrTestCaseJ4 {
    private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
  
@@ -39,7 +46,6 @@ public class ThreadDumpHandlerTest extends SolrTestCaseJ4 {
     initCore("solrconfig.xml", "schema.xml");
   }
 
-  
   public void testMonitor() throws Exception {
     assumeTrue("monitor checking not supported on this JVM",
                ManagementFactory.getThreadMXBean().isObjectMonitorUsageSupported());