You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/06/18 20:22:05 UTC
Review Request 70879: Updated webui Roles tab to consistently display
'-' for 0 entries.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70879/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Meng Zhu.
Repository: mesos
Description
-------
The Roles tab currently uses an inconsistent mix of '0', '0 B' and '-'
for displaying the allocation, guarantee, and limit. Since it's easier
to scan the table for non-empty entries when '-' is used, this updates
the every empty case to use '-'.
We may also want to consider using the empty string '' in the future,
as that may help make the table even easier to scan visually than '-'.
Diffs
-----
src/webui/app/roles/roles.html c8ac1ef6cdfbc6d6a3d5c2e619896e8656a9badf
Diff: https://reviews.apache.org/r/70879/diff/1/
Testing
-------
Ran manually, see screenshot.
File Attachments
----------------
post-changes
https://reviews.apache.org/media/uploaded/files/2019/06/18/ab42cf05-9252-4eed-a765-4126c5ed23a4__Screen_Shot_2019-06-18_at_4.16.49_PM.png
pre-changes
https://reviews.apache.org/media/uploaded/files/2019/06/18/29122c1d-dae3-4d4c-8a52-062971d603c0__Screen_Shot_2019-06-18_at_4.21.27_PM.png
Thanks,
Benjamin Mahler
Re: Review Request 70879: Updated webui Roles tab to consistently
display '-' for 0 entries.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70879/#review215962
-----------------------------------------------------------
Ship it!
LGTM
- Armand Grillet
On June 18, 2019, 10:22 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70879/
> -----------------------------------------------------------
>
> (Updated June 18, 2019, 10:22 p.m.)
>
>
> Review request for mesos, Armand Grillet and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Roles tab currently uses an inconsistent mix of '0', '0 B' and '-'
> for displaying the allocation, guarantee, and limit. Since it's easier
> to scan the table for non-empty entries when '-' is used, this updates
> the every empty case to use '-'.
>
> We may also want to consider using the empty string '' in the future,
> as that may help make the table even easier to scan visually than '-'.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html c8ac1ef6cdfbc6d6a3d5c2e619896e8656a9badf
>
>
> Diff: https://reviews.apache.org/r/70879/diff/1/
>
>
> Testing
> -------
>
> Ran manually, see screenshot.
>
>
> File Attachments
> ----------------
>
> post-changes
> https://reviews.apache.org/media/uploaded/files/2019/06/18/ab42cf05-9252-4eed-a765-4126c5ed23a4__Screen_Shot_2019-06-18_at_4.16.49_PM.png
> pre-changes
> https://reviews.apache.org/media/uploaded/files/2019/06/18/29122c1d-dae3-4d4c-8a52-062971d603c0__Screen_Shot_2019-06-18_at_4.21.27_PM.png
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70879: Updated webui Roles tab to consistently
display '-' for 0 entries.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70879/#review215953
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70877, 70879]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 18, 2019, 1:22 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70879/
> -----------------------------------------------------------
>
> (Updated June 18, 2019, 1:22 p.m.)
>
>
> Review request for mesos, Armand Grillet and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Roles tab currently uses an inconsistent mix of '0', '0 B' and '-'
> for displaying the allocation, guarantee, and limit. Since it's easier
> to scan the table for non-empty entries when '-' is used, this updates
> the every empty case to use '-'.
>
> We may also want to consider using the empty string '' in the future,
> as that may help make the table even easier to scan visually than '-'.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html c8ac1ef6cdfbc6d6a3d5c2e619896e8656a9badf
>
>
> Diff: https://reviews.apache.org/r/70879/diff/1/
>
>
> Testing
> -------
>
> Ran manually, see screenshot.
>
>
> File Attachments
> ----------------
>
> post-changes
> https://reviews.apache.org/media/uploaded/files/2019/06/18/ab42cf05-9252-4eed-a765-4126c5ed23a4__Screen_Shot_2019-06-18_at_4.16.49_PM.png
> pre-changes
> https://reviews.apache.org/media/uploaded/files/2019/06/18/29122c1d-dae3-4d4c-8a52-062971d603c0__Screen_Shot_2019-06-18_at_4.21.27_PM.png
>
>
> Thanks,
>
> Benjamin Mahler
>
>