You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/04/25 00:15:18 UTC
[GitHub] spark pull request: [SPARK-6214][CORE] - A simple expression langu...
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4937#issuecomment-96081013
This is a cool feature, but I'm not sure Spark needs its own in-house expression language. It seems like it belongs in, for example, the Typesafe Config project that Spark uses, or an adjunct to that project. This does introduce some tricky cases: when can what types of props expect to reference values from which sources? already a dark and tricky corner of the project. I feel like this may not add enough value to justify the overhead, which is not any comment on the quality of the idea, language or execution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org