final review of pull request 5

[Mike Beckerle <mb...@tresys.com>]

I have made a final set of review-driven changes to fix the typos and such found in the last review.


If this patch is now acceptable, it should be squashed from 3 to 1 commit before merging/rebase.


Who does that? The developer, or the person doing the merge/integration.

Re: final review of pull request 5

[Steve Lawrence <sl...@apache.org>]

On 11/16/2017 05:02 PM, Dave Fisher wrote:
> Hi -
> 
>> On Nov 16, 2017, at 1:56 PM, Mike Beckerle <mb...@tresys.com> wrote:
>>
>> I have made a final set of review-driven changes to fix the typos and such found in the last review.
>>
>>
>> If this patch is now acceptable, it should be squashed from 3 to 1 commit before merging/rebase.
>>
>>
>> Who does that? The developer, or the person doing the merge/integration.
> 
> Yes, either or both. It’s up to the project. The merge/integration must be a committer/PPMC member. From what I’ve seen in another project I would recommend that the developer be responsible for squashing.
> 
> Regards,
> Dave
> 

I'd agree with this. Seems reasonable for the original author to
squash/rebase/push once they have two +1's and no -1's if they are a
committer/PPMC. If the original author is not a committer/PPMC, then it
should probably be one of the people that gave a +1.

Re: final review of pull request 5

[Dave Fisher <da...@comcast.net>]

Hi -

> On Nov 16, 2017, at 1:56 PM, Mike Beckerle <mb...@tresys.com> wrote:
> 
> I have made a final set of review-driven changes to fix the typos and such found in the last review.
> 
> 
> If this patch is now acceptable, it should be squashed from 3 to 1 commit before merging/rebase.
> 
> 
> Who does that? The developer, or the person doing the merge/integration.

Yes, either or both. It’s up to the project. The merge/integration must be a committer/PPMC member. From what I’ve seen in another project I would recommend that the developer be responsible for squashing.

Regards,
Dave