You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:51:33 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request #3800: Logstash doris output plugin
morningman commented on a change in pull request #3800:
URL: https://github.com/apache/incubator-doris/pull/3800#discussion_r437229082
##########
File path: docs/en/extending-doris/logstash.md
##########
@@ -0,0 +1,198 @@
+---
Review comment:
You need to add this doc title in the side bar:
open the `docs/.vuepress/sidebar/en.js` and search `extending-doris/`
##########
File path: extension/logstash/logstash-output-doris.gemspec
##########
@@ -0,0 +1,44 @@
+=begin
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+=end
+Gem::Specification.new do |s|
+ s.name = 'logstash-output-doris'
+ s.version = '0.1.0'
+ s.licenses = ['Apache License (2.0)']
+ s.summary = "This output lets you `PUT` messages in a batched fashion to Doris HTTP endpoint"
+ s.description = "This gem is a logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not a stand-alone program"
+ s.require_paths = ["lib"]
+
+ # Files
+ s.files = Dir['lib/**/*','spec/**/*','*.gemspec','*.md','Gemfile','LICENSE' ]
+
+ # Tests
+ s.test_files = s.files.grep(%r{^(test|spec|features)/})
+
+ # Special flag to let us know this is actually a logstash plugin
+ s.metadata = { "logstash_plugin" => "true", "logstash_group" => "output" }
+
+ # Gem dependencies
+ s.add_runtime_dependency "logstash-core-plugin-api", ">= 1.60", "<= 2.99"
+ s.add_runtime_dependency 'mini_cache', ">= 1.0.0", "< 2.0.0"
+ s.add_runtime_dependency "rest-client", '>= 1.8.0'
+
+ s.add_development_dependency 'logstash-devutils'
Review comment:
Add version info for following 3 dependencies
##########
File path: docs/zh-CN/extending-doris/logstash.md
##########
@@ -0,0 +1,198 @@
+---
Review comment:
You need to add this doc title in the side bar:
open the `docs/.vuepress/sidebar/zh-CN.js` and search `扩展功能`
##########
File path: extension/logstash/logstash-output-doris.gemspec
##########
@@ -0,0 +1,44 @@
+=begin
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+=end
+Gem::Specification.new do |s|
+ s.name = 'logstash-output-doris'
+ s.version = '0.1.0'
+ s.licenses = ['Apache License (2.0)']
Review comment:
`Apache License (2.0)` seems not a valid license name in my env.
Should it be `Apache-2.0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org