You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/04/04 16:48:05 UTC
Review Request 70388: Replaced os.path.exists() with a proper check of
automake flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Bugs: MESOS-9699
https://issues.apache.org/jira/browse/MESOS-9699
Repository: mesos
Description
-------
Replaced os.path.exists() with a proper check of automake flags.
Diffs
-----
src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
Diff: https://reviews.apache.org/r/70388/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214372
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70387.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70387`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3082/mesos-review-70388
Relevant logs:
- [apply-review-70387.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3082/mesos-review-70388/logs/apply-review-70387.log):
```
70387.patch:1990: trailing whitespace.
70387.patch:2015: trailing whitespace.
70387.patch:2025: trailing whitespace.
70387.patch:2072: trailing whitespace.
70387.patch:2093: trailing whitespace.
error: missing binary patch data for '3rdparty/glog-0.4.0.tar.gz'
error: binary patch does not apply to '3rdparty/glog-0.4.0.tar.gz'
error: 3rdparty/glog-0.4.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On April 4, 2019, 4:48 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 4, 2019, 4:48 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214371
-----------------------------------------------------------
Bad review!
Reviews applied: [70388, 70387]
Error:
2019-04-04 18:13:29 URL:https://reviews.apache.org/r/70387/diff/raw/ [112367/112367] -> "70387.patch" [1]
70387.patch:1990: trailing whitespace.
70387.patch:2015: trailing whitespace.
70387.patch:2025: trailing whitespace.
70387.patch:2072: trailing whitespace.
70387.patch:2093: trailing whitespace.
error: missing binary patch data for '3rdparty/glog-0.4.0.tar.gz'
error: binary patch does not apply to '3rdparty/glog-0.4.0.tar.gz'
error: 3rdparty/glog-0.4.0.tar.gz: patch does not apply
- Mesos Reviewbot
On April 4, 2019, 9:48 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 4, 2019, 9:48 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214580
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On April 11, 2019, 10:11 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 11, 2019, 10:11 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214578
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70387, 70388]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 11, 2019, 10:11 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 11, 2019, 10:11 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/
-----------------------------------------------------------
(Updated April 11, 2019, 10:11 a.m.)
Review request for mesos and Benno Evers.
Bugs: MESOS-9699
https://issues.apache.org/jira/browse/MESOS-9699
Repository: mesos
Description
-------
Replaced os.path.exists() with a proper check of automake flags.
Diffs
-----
src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
Diff: https://reviews.apache.org/r/70388/diff/3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/
-----------------------------------------------------------
(Updated April 11, 2019, 10:10 a.m.)
Review request for mesos and Benno Evers.
Bugs: MESOS-9699
https://issues.apache.org/jira/browse/MESOS-9699
Repository: mesos
Description
-------
Replaced os.path.exists() with a proper check of automake flags.
Diffs
-----
src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
Diff: https://reviews.apache.org/r/70388/diff/3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214541
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70387', '70388']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3142/mesos-review-70388
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3142/mesos-review-70388/logs/mesos-tests.log):
```
I0410 19:45:02.478229 46772 master.cpp:1295] Agent 16ee8b63-d31c-43e9-ac77-b7303f145b99-S0 at slave(501)@192.10.1.4:59534 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0410 19:45:02.478229 46772 master.cpp:3333] Disconnecting agent 16ee8b63-d31c-43e9-ac77-b7303f145b99-S0 at slave(501)@192.10.1.4:59534 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0410 19:45:02.478229 46772 master.cpp:3352] Deactivating agent 16ee8b63-d31c-43e9-ac77-b7303f145b99-S0 at slave(501)@192.10.1.4:59534 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0410 19:45:02.479225 48000 hierarchical.cpp:392] Removed framework 16ee8b63-d31c-43e9-ac77-b7303f145b99-0000
I0410 19:45:02.479225 48000 hierarchical.cpp:829] Agent 16ee8b63-d31c-43e9-ac77-b7303f145b99-S0 deactivated
I0410 19:45:02.480255 46772 containerizer.cpp:2576] Destroying container 3030d2a7-91ba-4b1b-b5e7-5b0c1dcc9f47 in RUNNING state
I0410 19:45:02.480255 46772 containerizer.cpp:3278] Transitioning the state of container 3030d2a7-91ba-4b1b-b5e7-5b0c1dcc9f47 from RUNNING to DESTROYING
I0410 19:45:02.481281 46772 launcher.cpp:161] Asked to destroy container 3030d2a7-91ba-4b1b-b5e7-5b0c1dcc9f47
W0410 19:45:02.482372 45996 process.cpp:1423] Faile[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (788 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (805 ms total)
[----------] Global test environment tear-down
[==========] 1159 tests from 108 test cases ran. (607578 ms total)
[ PASSED ] 1157 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
2 FAILED TESTS
YOU HAVE 233 DISABLED TESTS
d to recv on socket WindowsFD::Type::SOCKET=8056 to peer '192.10.1.4:61930': IO failed with error code: The specified network name is no longer available.
W0410 19:45:02.482372 45996 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=9132 to peer '192.10.1.4:61931': IO failed with error code: The specified network name is no longer available.
I0410 19:45:02.567756 41176 containerizer.cpp:3117] Container 3030d2a7-91ba-4b1b-b5e7-5b0c1dcc9f47 has exited
I0410 19:45:02.599726 49100 master.cpp:1135] Master terminating
I0410 19:45:02.600733 45868 hierarchical.cpp:680] Removed agent 16ee8b63-d31c-43e9-ac77-b7303f145b99-S0
I0410 19:45:03.258083 45996 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 10, 2019, 6:59 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 10, 2019, 6:59 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214532
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70387, 70388]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 10, 2019, 1:59 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 10, 2019, 1:59 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/
-----------------------------------------------------------
(Updated April 10, 2019, 1:59 p.m.)
Review request for mesos and Benno Evers.
Bugs: MESOS-9699
https://issues.apache.org/jira/browse/MESOS-9699
Repository: mesos
Description
-------
Replaced os.path.exists() with a proper check of automake flags.
Diffs (updated)
-----
src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
Diff: https://reviews.apache.org/r/70388/diff/3/
Changes: https://reviews.apache.org/r/70388/diff/2-3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214531
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70387.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70387`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3139/mesos-review-70388
Relevant logs:
- [apply-review-70387.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3139/mesos-review-70388/logs/apply-review-70387.log):
```
70387.patch:11795: trailing whitespace.
70387.patch:11820: trailing whitespace.
70387.patch:11830: trailing whitespace.
70387.patch:11877: trailing whitespace.
70387.patch:11898: trailing whitespace.
error: patch failed: 3rdparty/versions.am:23
error: 3rdparty/versions.am: patch does not apply
```
- Mesos Reviewbot Windows
On April 10, 2019, 12:40 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
>
> (Updated April 10, 2019, 12:40 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9699
> https://issues.apache.org/jira/browse/MESOS-9699
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced os.path.exists() with a proper check of automake flags.
>
>
> Diffs
> -----
>
> src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
>
>
> Diff: https://reviews.apache.org/r/70388/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70388: Replaced os.path.exists() with a proper
check of automake flags.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/
-----------------------------------------------------------
(Updated April 10, 2019, 12:40 p.m.)
Review request for mesos and Benno Evers.
Changes
-------
Re-posted 70387 via parched rbtools (attempt to fix missing glog archive binary).
Bugs: MESOS-9699
https://issues.apache.org/jira/browse/MESOS-9699
Repository: mesos
Description
-------
Replaced os.path.exists() with a proper check of automake flags.
Diffs (updated)
-----
src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1
Diff: https://reviews.apache.org/r/70388/diff/2/
Changes: https://reviews.apache.org/r/70388/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko