[GitHub] cloudstack pull request: Strongswan vpn feature

[terbolous <gi...@git.apache.org>]

Github user terbolous commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/872#discussion_r48774570
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -479,13 +479,13 @@ def process(self):
     
         def deletevpn(self, ip):
             logging.info("Removing VPN configuration for %s", ip)
    -        CsHelper.execute("ipsec auto --down vpn-%s" % ip)
    -        CsHelper.execute("ipsec auto --delete vpn-%s" % ip)
    +        CsHelper.execute("ipsec down vpn-%s" % ip)
    +        CsHelper.execute("ipsec down vpn-%s" % ip)
    --- End diff --
    
    Is it required to do ipsec down twice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---