You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/30 18:59:54 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #20572: feat: Renders Explore in SPA
michael-s-molina opened a new pull request, #20572:
URL: https://github.com/apache/superset/pull/20572
### SUMMARY
Renders Explore in SPA
TODO
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TODO
### TESTING INSTRUCTIONS
TODO
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174324425
We need to replace links to Explore from Datasets List - we still use `<a>` there. However, I'm fine with doing that in a separate PR, since there's an edge case to consider - dataset can link to an external website instead of explore, and for external websites we can't use React Router links. We probably should first create a generic link component, which would detect if url is internal (if so, use React Router link) or external (use HTML anchor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r913260587
##########
superset/models/slice.py:
##########
@@ -286,14 +286,14 @@ def get_query_context(self) -> Optional[QueryContext]:
def get_explore_url(
self,
- base_url: str = "/superset/explore",
+ base_url: str = "/explore",
overrides: Optional[Dict[str, Any]] = None,
) -> str:
overrides = overrides or {}
form_data = {"slice_id": self.id}
form_data.update(overrides)
Review Comment:
Not sure if `overrides` will be recognized by the new explore endpoint, since it doesn't handle `form_data` param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1175045267
> Thanks for spotting that @zhaoyongjie @jinghua-qa ! The problem was that after using the SPA html template, the structure of the page changed a bit and the height of Explore container wasn't calculated correctly. I pushed a fix for that and confirmed that results pane is now displayed correctly when it's closed.
>
> @jinghua-qa I couldn't repro the problem with flashing/zooming, but it looks to me like it's connected to calculating the page height. Hopefully my latest commit fixes this issue as well
Thank you for submitting the fix! I'm just waiting for @zhaoyongjie and @jinghua-qa's approval to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174915989
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174920049
@kgabryje Ephemeral environment spinning up at http://34.216.136.31:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174746174
I have tried open some example charts, i also saw the issue that result/samples are missing, however example chart 'Most Dominant Platforms' is working fine
https://user-images.githubusercontent.com/81597121/177279948-8ffdfa0d-76b2-41a3-8d95-0edd7d90b4f8.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174641062
@zhaoyongjie Ephemeral environment spinning up at http://34.221.127.102:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174725710
> @michael-s-molina The results data pane seems lost.
Works for me 🤔
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/177276068-5773e324-eba4-4112-9b16-64b1a864cae0.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174966440
> @michael-s-molina Thank you very much for this long awaited PR Do you plan to make switching between `Home`, `Dashboards`, `Charts`, `SQL Editor` and `Data` tabs in SPA without reloading the browser page?
Hi @EugeneTorap. That's the plan for the whole SPA project. We're tackling it in phases so some of the pages may still be reloading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1175443317
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174640091
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1175049586
> We need to replace links to Explore from Datasets List - we still use `<a>` there. However, I'm fine with doing that in a separate PR, since there's an edge case to consider - dataset can link to an external website instead of explore, and for external websites we can't use React Router links. We probably should first create a generic link component, which would detect if url is internal (if so, use React Router link) or external (use HTML anchor)
Good point. Let's tackle it in a separate PR 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174757060
Found 2 issue when switching chart:
1, when i switching area chart to pie chart and big number, area chart will non-stop flashing before user update the chart
https://user-images.githubusercontent.com/81597121/177281177-f8da6e33-4d95-47e5-9524-0177f48ea251.mov
2, change chart to pie chart and big number chart through viz switchers, the chart will keep zoom out itself
https://user-images.githubusercontent.com/81597121/177281574-8822faac-e356-439b-aa79-0a0f3c5054f4.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #20572:
URL: https://github.com/apache/superset/pull/20572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20572: [WIP] feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r911969576
##########
superset-frontend/src/explore/exploreUtils/index.js:
##########
@@ -87,7 +87,7 @@ export function getURIDirectory(endpointType = 'base') {
) {
return '/superset/explore_json/';
}
- return '/superset/explore/';
+ return '/explore/';
Review Comment:
With this change saving chart won't work until another PR implementing saving chart isn't merged
<img width="637" alt="image" src="https://user-images.githubusercontent.com/15073128/176905186-e4004074-cc22-4a4a-96aa-3ab95304ce71.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #20572: [WIP] feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r912013234
##########
superset-frontend/src/explore/exploreUtils/index.js:
##########
@@ -87,7 +87,7 @@ export function getURIDirectory(endpointType = 'base') {
) {
return '/superset/explore_json/';
}
- return '/superset/explore/';
+ return '/explore/';
Review Comment:
You're right. I added a workaround to fix it and a `TODO` to remove the workaround with the next PR.
```
// TODO: This will be removed in the next PR that will change the logic to save a slice
url = url.replace('/explore', '/superset/explore');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174796019
Thanks for spotting that @zhaoyongjie @jinghua-qa ! The problem was that after using the SPA html template, the structure of the page changed a bit and the height of Explore container wasn't calculated correctly. I pushed a fix for that and confirmed that results pane is now displayed correctly when it's closed.
@jinghua-qa I couldn't repro the problem with flashing/zooming, but it looks to me like it's connected to calculating the page height. Hopefully my latest commit fixes this issue as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1172696020
@michael-s-molina Thank you very much for this long awaited PR
Do you plan to make switching between `Home`, `Dashboard`, `Chart`, `SQL Editor` and `Data` tabs in SPA without reloading the browser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20572: [WIP] feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1172327121
# [Codecov](https://codecov.io/gh/apache/superset/pull/20572?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20572](https://codecov.io/gh/apache/superset/pull/20572?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca9b9cd) into [master](https://codecov.io/gh/apache/superset/commit/b30f6a5db1c9d79d4837529b671090f4a908c056?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b30f6a5) will **decrease** coverage by `11.97%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #20572 +/- ##
===========================================
- Coverage 66.80% 54.83% -11.98%
===========================================
Files 1754 1752 -2
Lines 65566 65574 +8
Branches 6933 6933
===========================================
- Hits 43802 35957 -7845
- Misses 20010 27861 +7851
- Partials 1754 1756 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.66% <86.20%> (+0.04%)` | :arrow_up: |
| python | `58.03% <86.20%> (-24.85%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `50.67% <86.20%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20572?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/ExplorePage.tsx](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvRXhwbG9yZVBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/getDatasourceUid.ts](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldERhdGFzb3VyY2VVaWQudHM=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `58.77% <ø> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `58.45% <0.00%> (-27.06%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `34.74% <ø> (-42.64%)` | :arrow_down: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `55.88% <50.00%> (-0.37%)` | :arrow_down: |
| [superset-frontend/src/views/store.ts](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3N0b3JlLnRz) | `72.22% <50.00%> (-7.78%)` | :arrow_down: |
| [superset/views/explore.py](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZXhwbG9yZS5weQ==) | `91.66% <91.66%> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `66.66% <100.00%> (ø)` | |
| ... and [301 more](https://codecov.io/gh/apache/superset/pull/20572/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20572?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20572?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b30f6a5...ca9b9cd](https://codecov.io/gh/apache/superset/pull/20572?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r913260587
##########
superset/models/slice.py:
##########
@@ -286,14 +286,14 @@ def get_query_context(self) -> Optional[QueryContext]:
def get_explore_url(
self,
- base_url: str = "/superset/explore",
+ base_url: str = "/explore",
overrides: Optional[Dict[str, Any]] = None,
) -> str:
overrides = overrides or {}
form_data = {"slice_id": self.id}
form_data.update(overrides)
Review Comment:
Not sure if `overrides` will be recognized by the new explore endpoint, since it doesn't handle `form_data` param. We might want to look into that later and fix/refactor if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174730320
> > @michael-s-molina The results data pane seems lost.
>
> Works for me 🤔
>
> <img alt="image" width="1792" src="https://user-images.githubusercontent.com/15073128/177276068-5773e324-eba4-4112-9b16-64b1a864cae0.png">
Could you try to close the Results Pane and open a new tab?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #20572: feat: Renders Explore in SPA
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r913770158
##########
superset/models/slice.py:
##########
@@ -286,14 +286,14 @@ def get_query_context(self) -> Optional[QueryContext]:
def get_explore_url(
self,
- base_url: str = "/superset/explore",
+ base_url: str = "/explore",
overrides: Optional[Dict[str, Any]] = None,
) -> str:
overrides = overrides or {}
form_data = {"slice_id": self.id}
form_data.update(overrides)
Review Comment:
Thank you for spotting that! I investigated and it's trickier than it sounds. It's being used by Top N charts cache warm-up. I'll tackle this problem in a separate PR because it's not working anyway currently with `form_data_key`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org