You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/01 01:49:53 UTC

[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2388: Re-organize and rename aggregates physical plan

yjshen commented on code in PR #2388:
URL: https://github.com/apache/arrow-datafusion/pull/2388#discussion_r862412856


##########
ballista/rust/core/src/utils.rs:
##########
@@ -151,7 +151,7 @@ fn build_exec_plan_diagram(
     id: &mut AtomicUsize,
     draw_entity: bool,
 ) -> Result<usize> {
-    let operator_str = if plan.as_any().downcast_ref::<HashAggregateExec>().is_some() {
+    let operator_str = if plan.as_any().downcast_ref::<AggregateExec>().is_some() {
         "HashAggregateExec"

Review Comment:
   Thanks @andygrove. I've updated all these explanation strings and checked all occurrences of `hash_aggregate` and `HashAggregate`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org