You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jayvdb (via GitHub)" <gi...@apache.org> on 2025/12/11 20:21:24 UTC

[PR] fix(local): prefix filtering with Path::prefix_matches [arrow-rs-object-store]

jayvdb opened a new pull request, #574:
URL: https://github.com/apache/arrow-rs-object-store/pull/574

   The LocalFileSystem backend incorrectly treated the prefix parameter as a directory path, walking only that specific directory instead of filtering results with prefix_matches.
   
   Changes:
   - Walk from parent directory instead of treating prefix as directory
   - Filter results using Path::prefix_matches
   - Handle special case: listing exact file path returns empty
   
   # Which issue does this PR close?
   
   Fixes https://github.com/apache/arrow-rs-object-store/issues/573
   
   # Rationale for this change
    
   So the backends work in a similar way.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please call them out.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(local): prefix filtering with Path::prefix_matches [arrow-rs-object-store]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #574:
URL: https://github.com/apache/arrow-rs-object-store/pull/574#issuecomment-3646716759

   All of these tests pass on current main, nor do I really understand what this PR is trying to fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(local): prefix filtering with Path::prefix_matches [arrow-rs-object-store]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #574:
URL: https://github.com/apache/arrow-rs-object-store/pull/574#issuecomment-3662032822

   Chalking this up as being AI slop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(local): prefix filtering with Path::prefix_matches [arrow-rs-object-store]

Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on PR #574:
URL: https://github.com/apache/arrow-rs-object-store/pull/574#issuecomment-3645923864

   needs a clippy fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(local): prefix filtering with Path::prefix_matches [arrow-rs-object-store]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #574: fix(local): prefix filtering with Path::prefix_matches
URL: https://github.com/apache/arrow-rs-object-store/pull/574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org