You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/15 14:19:59 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #12659: [FLINK-18304][metrics] Document default reporter interval
azagrebin commented on a change in pull request #12659:
URL: https://github.com/apache/flink/pull/12659#discussion_r440209953
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
##########
@@ -58,9 +61,10 @@
.noDefaultValue()
.withDescription("The reporter class to use for the reporter named <name>.");
- public static final ConfigOption<String> REPORTER_INTERVAL =
+ public static final ConfigOption<Duration> REPORTER_INTERVAL =
Review comment:
looks like a breaking API change
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -119,7 +120,7 @@ public MetricRegistryImpl(MetricRegistryConfiguration config, Collection<Reporte
try {
Optional<String> configuredPeriod = reporterSetup.getIntervalSettings();
TimeUnit timeunit = TimeUnit.SECONDS;
- long period = 10;
+ long period = MetricOptions.REPORTER_INTERVAL.defaultValue().getSeconds();
Review comment:
maybe milliseconds are more secure to use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org