You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by Jim Donofrio <do...@gmail.com> on 2012/03/20 03:46:51 UTC
is it necessary to have profiles javadoc and deploy?
Is it necessary to have profiles javadoc and deploy? Since both are only
activated when we do a deploy, why not move the javadoc plugin under the
deploy profile and remove the below skipTests parameter so to do a
deploy we would just do:
mvn clean site deploy -Pdeploy
instead of:
mvn clean site verify
mvn clean deploy -Pdeploy -Pjavadoc
<!-- Don't re-run tests as part of the deploy build.
Note we use skipTests, not maven.test.skip, since the
latter skips
compilation too and we want to deploy tests. -->
<skipTests>true</skipTests>
Re: is it necessary to have profiles javadoc and deploy?
Posted by Brock Noland <br...@cloudera.com>.
Yes, I am not surprised our maven commands are hair-brained.
Everything maven-wise I have done, I copied (parroted) from some other
project. So if we can do things better, we should do it.
On Tue, Mar 20, 2012 at 12:06 AM, Jarek Jarcec Cecho <ja...@apache.org> wrote:
> +1 I'm fine with proposed change.
>
> Jarcec
>
> On Mon, Mar 19, 2012 at 10:46:51PM -0400, Jim Donofrio wrote:
>> Is it necessary to have profiles javadoc and deploy? Since both are
>> only activated when we do a deploy, why not move the javadoc plugin
>> under the deploy profile and remove the below skipTests parameter so
>> to do a deploy we would just do:
>> mvn clean site deploy -Pdeploy
>>
>> instead of:
>> mvn clean site verify
>> mvn clean deploy -Pdeploy -Pjavadoc
>>
>>
>>
>> <!-- Don't re-run tests as part of the deploy build.
>> Note we use skipTests, not maven.test.skip, since the
>> latter skips
>> compilation too and we want to deploy tests. -->
>> <skipTests>true</skipTests>
--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
Re: is it necessary to have profiles javadoc and deploy?
Posted by Jarek Jarcec Cecho <ja...@apache.org>.
+1 I'm fine with proposed change.
Jarcec
On Mon, Mar 19, 2012 at 10:46:51PM -0400, Jim Donofrio wrote:
> Is it necessary to have profiles javadoc and deploy? Since both are
> only activated when we do a deploy, why not move the javadoc plugin
> under the deploy profile and remove the below skipTests parameter so
> to do a deploy we would just do:
> mvn clean site deploy -Pdeploy
>
> instead of:
> mvn clean site verify
> mvn clean deploy -Pdeploy -Pjavadoc
>
>
>
> <!-- Don't re-run tests as part of the deploy build.
> Note we use skipTests, not maven.test.skip, since the
> latter skips
> compilation too and we want to deploy tests. -->
> <skipTests>true</skipTests>