You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2023/11/15 02:20:26 UTC
(skywalking) branch master updated: Fix JDBC Log query order. (#11544)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new eaac1c3ec4 Fix JDBC Log query order. (#11544)
eaac1c3ec4 is described below
commit eaac1c3ec44094b2810c65d7d087e646f1128f02
Author: weixiang1862 <65...@qq.com>
AuthorDate: Wed Nov 15 10:20:20 2023 +0800
Fix JDBC Log query order. (#11544)
---
docs/en/changes/changes.md | 1 +
.../oap/server/storage/plugin/jdbc/common/dao/JDBCLogQueryDAO.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index cfa8befdb9..5c360c2e14 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -38,6 +38,7 @@
* Fix cannot query zipkin traces with `annotationQuery` parameter in the JDBC related storage.
* Fix `limit` doesn't work for `findEndpoint` API in ES storage.
* Isolate MAL CounterWindow cache by metric name.
+* Fix JDBC Log query order.
#### UI
diff --git a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCLogQueryDAO.java b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCLogQueryDAO.java
index 52dc2cbc96..7c96b59f1e 100644
--- a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCLogQueryDAO.java
+++ b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCLogQueryDAO.java
@@ -122,7 +122,7 @@ public class JDBCLogQueryDAO implements ILogQueryDAO {
)
);
}
- final var comparator = Order.DES.equals(queryOrder) ?
+ final var comparator = Order.ASC.equals(queryOrder) ?
comparing(Log::getTimestamp) :
comparing(Log::getTimestamp).reversed();