You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tamaya.apache.org by alexsuter <gi...@git.apache.org> on 2018/06/28 14:16:34 UTC

[GitHub] incubator-tamaya-sandbox pull request #6: Proposal: Change default key-value...

GitHub user alexsuter opened a pull request:

    https://github.com/apache/incubator-tamaya-sandbox/pull/6

    Proposal: Change default key-value separator from :: to =

    I think this is more common. What do you think about that?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alexsuter/incubator-tamaya-sandbox patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tamaya-sandbox/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 3bfe419faaf28422ebf2af22bffabf57ebecb092
Author: Alex <al...@...>
Date:   2018-06-28T14:16:24Z

    Proposal: Change default key-value separator from :: to =
    
    I think this is more common. What do you think about that?

----


---

[GitHub] incubator-tamaya-sandbox issue #6: Proposal: Change default key-value separa...

Posted by alexsuter <gi...@git.apache.org>.

Github user alexsuter commented on the issue:

    https://github.com/apache/incubator-tamaya-sandbox/pull/6
  
    Thanks for feedback.
    This topic is currently under discussion here: https://issues.apache.org/jira/browse/TAMAYA-345?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=16538609


---

[GitHub] incubator-tamaya-sandbox issue #6: Proposal: Change default key-value separa...

Posted by acoburn <gi...@git.apache.org>.

Github user acoburn commented on the issue:

    https://github.com/apache/incubator-tamaya-sandbox/pull/6
  
    With this change, you would also need to adjust some of the tests, particularly those defined here:
    https://github.com/apache/incubator-tamaya-sandbox/blob/master/collections/src/test/resources/META-INF/javaconfiguration.properties#L38-L56 along with the relevant javadocs in `collections/src/test/java/org/...`



---