You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2022/06/14 08:20:36 UTC

[GitHub] [isis] andi-huber commented on a diff in pull request #981: Various fixes to error page rendering

andi-huber commented on code in PR #981:
URL: https://github.com/apache/isis/pull/981#discussion_r896521074


##########
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/home/HomePage.java:
##########
@@ -61,15 +61,8 @@ private void buildGui() {
 
         if(ManagedObjects.isSpecified(homePageAdapter)) {
             val requestCycle = RequestCycle.get();
-            try {
-                val page = EntityPage.forAdapter(getCommonContext(), homePageAdapter);
-                requestCycle.setResponsePage(page);
-            } catch (Exception ignore) {

Review Comment:
   for reference: Martin suggests to remove the catch clause. I agree, its not up to the HomePage class to be that smart here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org