You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/03 17:09:50 UTC
[GitHub] [dubbo-go] ray2011 opened a new pull request, #1919: Fix: ProviderConfig.Filter and ReferenceConfig.Filter not work
ray2011 opened a new pull request, #1919:
URL: https://github.com/apache/dubbo-go/pull/1919
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
ProviderConfig.Filter and ReferenceConfig.Filter not work. Fix them
**You should pay attention to items below to ensure your pr passes our ci test**
We do not merge pr with ci tests failed
- [x] All ut passed (run 'go test ./...' in project root)
- [x] After go-fmt ed , run 'go fmt project' using goland.
- [x] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
- [x] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
- [x] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
- [x] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1919: Fix: ProviderConfig.Filter and ReferenceConfig.Filter not work
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1919:
URL: https://github.com/apache/dubbo-go/pull/1919#issuecomment-1146492202
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1919?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1919](https://codecov.io/gh/apache/dubbo-go/pull/1919?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (026711b) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/0935a8e5405c877dd16c7003115ee8b0f32476e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0935a8e) will **decrease** coverage by `0.02%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## 3.0 #1919 +/- ##
==========================================
- Coverage 44.98% 44.96% -0.03%
==========================================
Files 287 287
Lines 17130 17135 +5
==========================================
- Hits 7706 7704 -2
- Misses 8613 8618 +5
- Partials 811 813 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `31.97% <33.33%> (-0.33%)` | :arrow_down: |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `53.04% <100.00%> (+0.28%)` | :arrow_up: |
| [cluster/loadbalance/ringhash/ring.go](https://codecov.io/gh/apache/dubbo-go/pull/1919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yaW5naGFzaC9yaW5nLmdv) | `84.50% <0.00%> (-2.82%)` | :arrow_down: |
| [config/graceful\_shutdown\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duX2NvbmZpZy5nbw==) | `73.33% <0.00%> (-1.67%)` | :arrow_down: |
| [remoting/xds/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcveGRzL2NsaWVudC5nbw==) | `53.23% <0.00%> (-0.77%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1919?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1919?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0935a8e...026711b](https://codecov.io/gh/apache/dubbo-go/pull/1919?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1919: Fix: ProviderConfig.Filter and ReferenceConfig.Filter not work
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on PR #1919:
URL: https://github.com/apache/dubbo-go/pull/1919#issuecomment-1146489726
@ray2011 pls submit a issue to describe the problem carefully and then link this issue in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1919: Fix: ProviderConfig.Filter and ReferenceConfig.Filter not work
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on PR #1919:
URL: https://github.com/apache/dubbo-go/pull/1919#issuecomment-1146550137
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1919: Fix: ProviderConfig.Filter and ReferenceConfig.Filter not work
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on PR #1919:
URL: https://github.com/apache/dubbo-go/pull/1919#issuecomment-1146489965
what's more, the current main branch is 3.0. so I have change your target branch to 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1919: Fix: ProviderConfig.Filter and ReferenceConfig.Filter not work
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged PR #1919:
URL: https://github.com/apache/dubbo-go/pull/1919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org