Re: [PR] fix(test): Exclude Cloudberry from gpdb6_objects.sql execution [cloudberry-gpbackup]

["robertmu (via GitHub)" <gi...@apache.org>]

robertmu commented on PR #39:
URL: https://github.com/apache/cloudberry-gpbackup/pull/39#issuecomment-3264349505

   This approach differs from the one taken in [PR #38](https://github.com/apache/cloudberry-gpbackup/pull/38), and the reasoning is strategic:
   
   -   In **PR #38**, the issue was a legacy **postfix operator**. This is an outdated feature that is no longer supported in modern PostgreSQL and will not be supported in Cloudberry. Therefore, the most direct and permanent solution was to modify the `gpdb4_objects.sql` file itself to use a modern, compatible binary operator.
   
   -   In **this PR**, the issue is the lack of support for **ENUM as a distribution key**. This is a temporary limitation in our current target, Cloudberry 2.0, and this feature is expected to be fully supported in **Cloudberry 2.1**.
   
   For this reason, we chose a less invasive approach: temporarily skipping the execution of `gpdb6_objects.sql` in the Go test logic. This keeps the SQL file intact for future compatibility and makes it trivial to re-enable the test for Cloudberry 2.1 by simply removing the conditional check.
   
   See: apache/cloudberry#1300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org