You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2020/10/19 13:11:16 UTC

[GitHub] [roller] mbien opened a new pull request #69: Fix for dusty integration tests

mbien opened a new pull request #69:
URL: https://github.com/apache/roller/pull/69


   integration tests should be working again.
   
   commit msg:
    - the pom was broken possibly from a merge conflict from some time ago
    - fixed some paths and dependencies
    - adapted for firefox driver api changes
    - some tests needed minor updates due to the new bootstrap UI
    - some tests threw StaleElementReference exceptions when they tried to access elements after
      clicking a hyperlink which reloaded the page; fixed that too
   
   tested with:
    cd it-selenium
    mvn clean integration-test -Dwebdriver.gecko.driver=/path/to/geckodriver
   
   used:
    geckodriver v0.26.0 on 64bit linux, latest firefox, jdk 14 and everything worked fine.
   
   note:
    do a mvn install of the roller root project first. Doing this for ./app is not sufficient
    since the tests look for the project pom/war in local repo, not roller.war.
   note2:
    the test will display a few meters of jetty "class scanned from multiple locations" warnings
    since the classpath is apperently set to target/ and the local copy in the maven repo.
    Isn't convention over configuration great? I did not further attempt to fix this after trying
    out some different dependency scopes without any effect.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] mbien commented on pull request #69: Fix for dusty integration tests

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #69:
URL: https://github.com/apache/roller/pull/69#issuecomment-712171297


   @snoopdave forgot to ping :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] snoopdave merged pull request #69: Fix for dusty integration tests

Posted by GitBox <gi...@apache.org>.
snoopdave merged pull request #69:
URL: https://github.com/apache/roller/pull/69


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org