You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/07/07 09:40:43 UTC
[GitHub] [lucenenet] NightOwl888 opened a new issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
NightOwl888 opened a new issue #305:
URL: https://github.com/apache/lucenenet/issues/305
The benchmarks project was designed to be able to load user-defined projects to run. In Java, this could be done with a single string to identify the types to load, however, .NET requires a reference to the actual assembly in order to read the types from it.
We currently have it set up to read all types from all assemblies that are referenced, but this causes the `Lucene.Net.Tests.Benchmark.ByTask.Tasks.Alt::TestWithoutAlt()` test to fail because in Java the types were supposed to be loaded on demand. So, we need to investigate the best way to load types from external assemblies in .NET to run benchmarks on from the `lucene-cli` tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on issue #305:
URL: https://github.com/apache/lucenenet/issues/305#issuecomment-704297788
@jeme
Thanks, you were correct in that the original issue was lacking some context, and I have added more information to better explain the task.
The `Lucene.Net.Benchmark` project was designed to work either as a library that users can extend or as an executable that can just be run. The issue crops up in the latter case where we need some sort of a "plug in" architecture so the end user can supply their own assembly to run it against. Java has a native feature to do this, but .NET does not.
@Shazwazza
Although I think that we should look into leveraging BenchmarkDotNet for Lucene.Net.Benchmark at some point, the current incarnation is just a line-by-line port from Java. The Lucene.Net.Benchmark project uses a DSL to control the configuration of a benchmark, including strings that are meant for loading external types.
Since the commands are essentially run-once I don't believe there will be any issues with "unloading" to worry about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on issue #305:
URL: https://github.com/apache/lucenenet/issues/305#issuecomment-704346962
Actually, come to think of it, that brings up another potential gap that wasn't previously considered. The `lucene-cli` tool is targeted at .NET Core 3.1 only. This may be an issue if the end user needs to load .NET Framework assemblies into its context in order to benchmark the types within them.
Potential solutions/workarounds:
- Don't support .NET Framework in the CLI, require .NET Framework users to compile their DLL as .NET Standard in order to benchmark in .NET Core 3.1 or use the DLL and build their own wrapper CLI for .NET Framework
- Create a separate version of the tool for .NET Framework (possibly even move the benchmark commands to a separate tool)
I know that in early versions of .NET Core, it was possible to load .NET Framework assemblies with certain conditions/limitation, which could also potentially be explored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] Shazwazza commented on issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
Posted by GitBox <gi...@apache.org>.
Shazwazza commented on issue #305:
URL: https://github.com/apache/lucenenet/issues/305#issuecomment-704197007
For netcore this is really easy and you can unload them. In .NET Framework this is more difficult and you cannot unload them unless you create and destroy custom AppDomains at runtime which is possible but you cannot flow data between the domains unless you are using string serialization or remoting (all ugly). In netcore you just use AssemblyLoadContext, there are samples here https://github.com/dotnet/samples/tree/master/core/tutorials/Unloading (https://github.com/dotnet/samples/blob/master/core/tutorials/Unloading/Host/Program.cs)
But the way benchmarkdotnet works is underneath for the execution it dynamically creates a netcore project and compiles it with the references that you are telling it to, it then runs the benchmarks against the compiled .exe output. So by using benchmarkdotnet you are sort of already loading in external assemblies. It's been a while since I looked but you can control how benchmarkdotnet builds it's program.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] jeme commented on issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
Posted by GitBox <gi...@apache.org>.
jeme commented on issue #305:
URL: https://github.com/apache/lucenenet/issues/305#issuecomment-704186131
Loading types in from non-referenced assemblies are fairly simple in .NET, if they reside in a different location (folder wise) one has to implement some assembly resolution handling, but I have done that many times in the past.
In only really gets complicated if we begin to talk about having the loaded assemblies isolated. This is often done to allow for loading and then unloading them again. However since this is a command line then that sounds irrelevant.
But I think the Issue lacks more context, this could be some examples or references to documentation of how the Java version works. As well as how do we envision this should work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] Shazwazza commented on issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
Posted by GitBox <gi...@apache.org>.
Shazwazza commented on issue #305:
URL: https://github.com/apache/lucenenet/issues/305#issuecomment-704629147
> Don't support .NET Framework in the CLI,
That would be my vote, I just don't see it worth spending a whole lot of time for .NET Framework compatibility. If the main project supports it then I think that's enough IMO.
> I know that in early versions of .NET Core, it was possible to load .NET Framework assemblies with certain conditions/limitation, which could also potentially be explored.
Yep we were exploiting that in our own builds and it sort of still works in netcore 3, however in netcore 3 official support for it has been entirely dropped. Like if you drop a dll into the /bin it will 'work' but i think it really depends on what's in the DLL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] Shazwazza commented on issue #305: Investigate how we can load external assemblies when running Lucene.Net.Benchmarks on the command line
Posted by GitBox <gi...@apache.org>.
Shazwazza commented on issue #305:
URL: https://github.com/apache/lucenenet/issues/305#issuecomment-704315848
oh yes my bad, i was confused with the benchmarkdotnet project(s) that we have, this one is different.
> Since the commands are essentially run-once I don't believe there will be any issues with "unloading" to worry about.
If its for netcore 3 then AssemblyLoadContext is still the way to do it whether you unload or not. This is a nice post about it https://codetherapist.com/blog/netcore3-plugin-system/ If it's not netcore 3 then you can use Assembly.Load(name) if you want it loaded correctly (with fusion) but then the assembly needs to be in your probing paths (i.e. /bin), else you can load with Assembly.LoadFrom(filename) or Assembly.Load(bytes) but if you do that, the assembly will not be loaded in the same context. This is all different depending on the platform you are running on. In Net Framework this is all super ugly and you need to know about the 3 load contexts: Default, Load-From, No Context, see https://docs.microsoft.com/en-us/dotnet/framework/deployment/best-practices-for-assembly-loading but basically dealing with anything but the Default is a pain and you will almost always need an AppDomain.AssemblyResolve event, but you might get success with LoadFrom
netcore has fixed all this nonsense :) so depends on what it needs to run on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org