You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Roman S. Bushmanov (JIRA)" <ji...@apache.org> on 2007/05/25 13:53:16 UTC
[jira] Created: (HARMONY-3981) [drlvm][init] command line options
order should not matter
[drlvm][init] command line options order should not matter
----------------------------------------------------------
Key: HARMONY-3981
URL: https://issues.apache.org/jira/browse/HARMONY-3981
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Roman S. Bushmanov
The command
java -cp <classpath> -verify <class>
executes the specified class while the command
java -verify -cp <classpath> <class>
prints the following error message and returns.
Unknown option <classpath>
Use java -help to get help on command line options
Both commands works fine for RI.
Affected tests:
functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
(see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3981) [classlib][launcher] command line
options order should not matter
Posted by "Nina Rinskaya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502670 ]
Nina Rinskaya commented on HARMONY-3981:
----------------------------------------
The issue wasn't reproduced on EUT tests, r545288.
> [classlib][launcher] command line options order should not matter
> -----------------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Roman S. Bushmanov
> Assignee: Alexei Zakharov
> Attachments: H3981.patch
>
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3981) [classlib][launcher] command line
options order should not matter
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3981:
---------------------------------------
Component/s: (was: DRLVM)
Classlib
Summary: [classlib][launcher] command line options order should not matter (was: [drlvm][init] command line options order should not matter)
Updated summary according to evaluation.
> [classlib][launcher] command line options order should not matter
> -----------------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Roman S. Bushmanov
> Assignee: Alexei Zakharov
> Attachments: H3981.patch
>
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3981) [classlib][launcher] command line
options order should not matter
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov closed HARMONY-3981.
------------------------------------
Good, thanks Nina. Issue closed.
> [classlib][launcher] command line options order should not matter
> -----------------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Roman S. Bushmanov
> Assignee: Alexei Zakharov
> Attachments: H3981.patch
>
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3981) [drlvm][init] command line options
order should not matter
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3981:
--------------------------------------
Attachment: H3981.patch
This is actually the laucncher issue, so this is [classlib][launcher] bug (please get the summary updated)...
The following code causes the issue:
modules/luni/src/main/native/launcher/shared/main.c, lines 945-981:
for (i = 1; i < classArg; i++)
{
[skipped...]
/* special coding for -classpath and -cp */
/* they get passed to the vm as -Djava.class.path */
if ((strcmp (argv[i], "-cp") == 0)
|| (strcmp (argv[i], "-classpath") == 0))
{
[skipped...]
i++; /*skip next arguement */
}
else if (strcmp(argv[i], "-verify")==0)
{
options[j].optionString="-Xverify";
i++; ///////////////////// THIS IS WRONG INCREMENT
[skipped...]
}
}
}
So, the argument right after '-verify' one was always missed (it is interesting why only EUT was affected)...
The attached patch fixing this issue (sorry, it is not really complex)...
Thanks
Vladimir Beliaev
> [drlvm][init] command line options order should not matter
> ----------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Roman S. Bushmanov
> Attachments: H3981.patch
>
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3981) [drlvm][init] command line options
order should not matter
Posted by "Nina Rinskaya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501448 ]
Nina Rinskaya commented on HARMONY-3981:
----------------------------------------
The issue affects Eclipse Unit Tests suite (org.eclipse.jdt.core.tests.eval): ~300 tests fail because when the tests invoke VM, "-verify" option precedes "-cp" option and "-cp" is then "lost". See HARMONY-3556 for reproducing details.
> [drlvm][init] command line options order should not matter
> ----------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Roman S. Bushmanov
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3981) [drlvm][init] command line options
order should not matter
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov reassigned HARMONY-3981:
----------------------------------------
Assignee: Alexei Zakharov
> [drlvm][init] command line options order should not matter
> ----------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Roman S. Bushmanov
> Assignee: Alexei Zakharov
> Attachments: H3981.patch
>
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3981) [classlib][launcher] command line
options order should not matter
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-3981.
--------------------------------------
Resolution: Fixed
Thanks for the patch Vladimir. It was applied at the revision 545138. Please verify it is ok.
> [classlib][launcher] command line options order should not matter
> -----------------------------------------------------------------
>
> Key: HARMONY-3981
> URL: https://issues.apache.org/jira/browse/HARMONY-3981
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Roman S. Bushmanov
> Assignee: Alexei Zakharov
> Attachments: H3981.patch
>
>
> The command
> java -cp <classpath> -verify <class>
> executes the specified class while the command
> java -verify -cp <classpath> <class>
> prints the following error message and returns.
> Unknown option <classpath>
> Use java -help to get help on command line options
> Both commands works fine for RI.
> Affected tests:
> functional/org/apache/harmony/test/func/vm/cli/verify/verify.xml
> (see HARMONY-3528)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.