[GitHub] [airflow] kaxil commented on a change in pull request #9174: Don't use the term "whitelist" - language matters

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #9174:
URL: https://github.com/apache/airflow/pull/9174#discussion_r436552008



##########
File path: airflow/providers/apache/hive/operators/hive_stats.py
##########
@@ -67,17 +68,26 @@ def __init__(self,
                  table: str,
                  partition: str,
                  extra_exprs: Optional[Dict] = None,
-                 col_blacklist: Optional[List] = None,
+                 excluded_columns: Optional[List] = None,
                  assignment_func: Optional[Callable[[str, str], Optional[Dict]]] = None,
                  metastore_conn_id: str = 'metastore_default',
                  presto_conn_id: str = 'presto_default',
                  mysql_conn_id: str = 'airflow_db',
                  *args, **kwargs) -> None:
+        if 'col_blacklist' in kwargs:

Review comment:
       This will still fail precommit check I think, we can exlcude this file or add some kind of "#ignore" that we can check in pyprep in precommit. Or ezclude this file in that precommit check




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org