[jira] Resolved: (JCR-892) XML export (stream) doesn't initialize TransformerHandler properly

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCR-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-892.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
         Assignee: Julian Reschke

Thanks for the fixes! I'm aplied the same change also to contrib/backup in revision 540525.

Resolved as Fixed.

> XML export (stream) doesn't initialize TransformerHandler properly
> ------------------------------------------------------------------
>
>                 Key: JCR-892
>                 URL: https://issues.apache.org/jira/browse/JCR-892
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: contrib PMs
>            Reporter: Julian Reschke
>         Assigned To: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> For instance, in SessionImpl.java:
>     public void exportSystemView(String absPath, OutputStream out,
>                                  boolean skipBinary, boolean noRecurse)
>             throws IOException, PathNotFoundException, RepositoryException {
>         SAXTransformerFactory stf = (SAXTransformerFactory) SAXTransformerFactory.newInstance();
>         try {
>             TransformerHandler th = stf.newTransformerHandler();
>             th.setResult(new StreamResult(out));
>             th.getTransformer().setParameter(OutputKeys.METHOD, "xml");
>             th.getTransformer().setParameter(OutputKeys.ENCODING, "UTF-8");
>             th.getTransformer().setParameter(OutputKeys.INDENT, "no");
>             exportSystemView(absPath, th, skipBinary, noRecurse);
>         } catch (TransformerException te) {
>             throw new RepositoryException(te);
>         } catch (SAXException se) {
>             throw new RepositoryException(se);
>         }
>     }
> (1) It should be "setOutputProperty()", not "setParameter()",
> (2) My tests show that setting the parameters only has an effect when done before calling setResult()
> That being said, the effect is minor, as the default settings for the TransformerHandler seem to be correct anway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.