You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/07/19 23:54:30 UTC
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13886
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 73 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13886/1
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 1: -Code-Review
+2 was a mistake.
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2019 22:28:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:37:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 1:
(3 comments)
I leave some minor comments. Thank you for the docs!
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@137
PS1, Line 137: <varname>json_str</varname> is invalid. </p>
Will also return NULL if nothing is selected, for example:
impala-shell> get_json_object('{"a": 1}', '$.b');
NULL
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@143
PS1, Line 143: <li> * : Denotes the wildcard for [] </li>
"*" can also be wildcard for ".", for example:
impala-shell> select get_json_object('{"a":true, "b":false, "c":true}', '$.*');
[true,false,true]
More examples can be found here: https://github.com/apache/impala/blob/4cc3ff9c6763de10236df351a47324d662766de3/be/src/exprs/expr-test.cc#L9787-L9928
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@288
PS1, Line 288: Each call to <codeph>UUID()</codeph> produces a new arbitrary value.
Is this relative to the get_json_object function?
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jul 2019 21:58:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/393/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 23:54:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/398/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:33:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:
http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@143
PS2, Line 143: of
> nit: or
Done
http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@199
PS2, Line 199: 'NULL','NULL','3'</codeblock>
> Looks like we only give examples for "." and "*". It'd be better if we can
Done
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:31:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:
http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@143
PS2, Line 143: of
nit: or
http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@199
PS2, Line 199: 'NULL','NULL','3'</codeblock>
Looks like we only give examples for "." and "*". It'd be better if we can add one more example for "[]" or "[*]". E.g.
---- QUERY
SELECT GET_JSON_OBJECT(t.json, '$[1]'),
GET_JSON_OBJECT(t.json, '$[*]')
FROM (VALUES (
('["a", "b", "c"]' AS json),
('["a", "b"]'),
('["a"]')
)) t
---- RESULTS
'b','["a","b","c"]'
'b','["a","b"]'
'NULL','a'
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:25:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Reviewed-on: http://gerrit.cloudera.org:8080/13886
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 112 insertions(+), 26 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Quanlong Huang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/398/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:14:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13886
to look at the new patch set (#2).
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 98 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13886/2
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@137
PS1, Line 137: <varname>json_str</varname> is invalid. </p>
> Will also return NULL if nothing is selected, for example:
Done
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@143
PS1, Line 143: <li> * : Denotes the wildcard for [] </li>
> "*" can also be wildcard for ".", for example:
Done
http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@288
PS1, Line 288: Each call to <codeph>UUID()</codeph> produces a new arbitrary value.
> Is this relative to the get_json_object function?
No, I just piggybacked an editorial fix.
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2019 22:11:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/393/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jul 2019 00:16:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13886
to look at the new patch set (#3).
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 112 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13886/3
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 1:
Could you review this doc patch?
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2019 20:32:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/399/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:35:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/399/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:31:52 +0000
Gerrit-HasComments: No