You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/24 06:53:58 UTC
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15542
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
[util] set CURLOPT_NOPROXY for EasyCurl
As it turned out, some environments set 'http_proxy' and 'https_proxy'
environment variables. This makes results unreliable for test scenarios
which fetch information from the embedded Kudu webserver.
This patch addresses that by programmatically setting CURLOPT_NOPROXY
to "*" wild-card by default, effectively disabling any proxying that
might otherwise occur if the mentioned environment variables were set.
Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
---
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
2 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/15542/1
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h
File src/kudu/util/curl_util.h:
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@123
PS1, Line 123: CURL* curl_;
> Done
Not done?
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@127
PS1, Line 127: f host
> Done
Not done?
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 07:39:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
[util] set CURLOPT_NOPROXY for EasyCurl
As it turned out, some environments set 'http_proxy' and 'https_proxy'
environment variables. This makes results unreliable for test scenarios
which fetch information from the embedded Kudu webserver.
This patch addresses that by programmatically setting CURLOPT_NOPROXY
to "*" wild-card by default, effectively disabling any proxying that
might otherwise occur if the mentioned environment variables were set.
Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Reviewed-on: http://gerrit.cloudera.org:8080/15542
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
2 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 13:42:49 +0000
Gerrit-HasComments: No
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h
File src/kudu/util/curl_util.h:
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@123
PS1, Line 123: // A comma-separated list of host names to disable proxying request to
This is fairly duplicative w.r.t. the documentation of set_noproxy. Could you cherry-pick the novel bits into that doc and drop this one?
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@127
PS1, Line 127: ussued
issued
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 24 Mar 2020 06:56:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h
File src/kudu/util/curl_util.h:
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@93
PS1, Line 93: noproxy_ = noproxy;
> warning: parameter 'noproxy' is passed by value and only copied once; consi
Done
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@123
PS1, Line 123: // A comma-separated list of host names to disable proxying request to
> This is fairly duplicative w.r.t. the documentation of set_noproxy. Could y
Done
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@127
PS1, Line 127: ussued
> issued
Done
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 07:38:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15542
to look at the new patch set (#2).
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
[util] set CURLOPT_NOPROXY for EasyCurl
As it turned out, some environments set 'http_proxy' and 'https_proxy'
environment variables. This makes results unreliable for test scenarios
which fetch information from the embedded Kudu webserver.
This patch addresses that by programmatically setting CURLOPT_NOPROXY
to "*" wild-card by default, effectively disabling any proxying that
might otherwise occur if the mentioned environment variables were set.
Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
---
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
2 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/15542/2
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15542
to look at the new patch set (#3).
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
[util] set CURLOPT_NOPROXY for EasyCurl
As it turned out, some environments set 'http_proxy' and 'https_proxy'
environment variables. This makes results unreliable for test scenarios
which fetch information from the embedded Kudu webserver.
This patch addresses that by programmatically setting CURLOPT_NOPROXY
to "*" wild-card by default, effectively disabling any proxying that
might otherwise occur if the mentioned environment variables were set.
Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
---
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
2 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/15542/3
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h
File src/kudu/util/curl_util.h:
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@123
PS1, Line 123: CURL* curl_;
> Not done?
Whoops, indeed -- forgot to drop this part.
Now it's done.
http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@127
PS1, Line 127: f host
> Not done?
It's done now.
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 07:48:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] set CURLOPT NOPROXY for EasyCurl
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 07:52:50 +0000
Gerrit-HasComments: No