[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8219: Support schema permissions

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8219: Support schema permissions 
URL: https://github.com/apache/incubator-superset/pull/8219#discussion_r343237008
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -292,6 +292,10 @@ def unique_name(self) -> str:
         return self.verbose_name or self.cluster_name
 
 
+sa.event.listen(DruidCluster, "after_insert", security_manager.set_perm)
+sa.event.listen(DruidCluster, "after_update", security_manager.set_perm)
 
 Review comment:
   Is it possible to implement this feature without model triggers? I find that they tend to embed business logic in the ORM and can lead to difficult-to-diagnose bugs down the line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org