You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/14 15:27:06 UTC
[GitHub] [kafka] Smeb opened a new pull request, #12991: MINOR: improve error message in ClientUtils
Smeb opened a new pull request, #12991:
URL: https://github.com/apache/kafka/pull/12991
Minor, but it would have saved a little time debugging invalid urls that were being set for bootstrap.servers in our configuration. It wasn't immediately obvious that the issue was a missing port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb commented on pull request #12991: MINOR: improve error message in ClientUtils
Posted by GitBox <gi...@apache.org>.
Smeb commented on PR #12991:
URL: https://github.com/apache/kafka/pull/12991#issuecomment-1351634035
Does this need tests? Happy to add some for the behaviour if you think it's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb closed pull request #12991: MINOR: improve error message in ClientUtils
Posted by GitBox <gi...@apache.org>.
Smeb closed pull request #12991: MINOR: improve error message in ClientUtils
URL: https://github.com/apache/kafka/pull/12991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb commented on pull request #12991: MINOR: improve error message in ClientUtils
Posted by GitBox <gi...@apache.org>.
Smeb commented on PR #12991:
URL: https://github.com/apache/kafka/pull/12991#issuecomment-1351675483
Ah - this doesn't work because getHost returns null if the port is not set. I'll revisit (and add some tests) and reopen this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb commented on pull request #12991: MINOR: improve error message in ClientUtils
Posted by GitBox <gi...@apache.org>.
Smeb commented on PR #12991:
URL: https://github.com/apache/kafka/pull/12991#issuecomment-1351675208
Ah - this doesn't work because `getHost` returns null if the port is not set. I'll revisit (and add some tests) and reopen this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org