You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/01/22 03:14:04 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39699: [SPARK-41772][CONNECT][PYTHON] Fix incorrect column name in `withField`'s doctest
zhengruifeng opened a new pull request, #39699:
URL: https://github.com/apache/spark/pull/39699
### What changes were proposed in this pull request?
Fix incorrect column name in `withField`'s doctest
```
pyspark.sql.connect.column.Column.withField
Failed example:
df.withColumn('a', df['a'].withField('b', lit(3))).select('a.b').show()
Expected:
+---+
| b|
+---+
| 3|
+---+
Got:
+---+
|a.b|
+---+
| 3|
+---+
<BLANKLINE>
```
### Why are the changes needed?
for parity
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
added UT and enabled doctest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39699: [SPARK-41772][CONNECT][PYTHON] Fix incorrect column name in `withField`'s doctest
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #39699: [SPARK-41772][CONNECT][PYTHON] Fix incorrect column name in `withField`'s doctest
URL: https://github.com/apache/spark/pull/39699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39699: [SPARK-41772][CONNECT][PYTHON] Fix incorrect column name in `withField`'s doctest
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #39699:
URL: https://github.com/apache/spark/pull/39699#issuecomment-1399443025
@HyukjinKwon thanks, merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org