You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/11/23 03:24:12 UTC
Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1783
https://issues.apache.org/jira/browse/SQOOP-1783
Repository: sqoop-sqoop2
Description
-------
I've added automated test as suggested on the JIRA.
You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
Diffs
-----
pom.xml e626c7d
test/pom.xml cafa250
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/28373/diff/
Testing
-------
The new test is passing!
Thanks,
Jarek Cecho
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/
-----------------------------------------------------------
(Updated Dec. 13, 2014, 5:56 p.m.)
Review request for Sqoop.
Changes
-------
Rebased on current head of sqoop2 branch.
Bugs: SQOOP-1783
https://issues.apache.org/jira/browse/SQOOP-1783
Repository: sqoop-sqoop2
Description
-------
I've added automated test as suggested on the JIRA.
You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
Diffs (updated)
-----
pom.xml efb9659
test/pom.xml 35d36c1
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28373/diff/
Testing
-------
The new test is passing!
Thanks,
Jarek Cecho
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Nov. 26, 2014, 9:44 p.m., Abraham Elmahrek wrote:
> > The upgrade tests are failing for me:
> > <error message="Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details." type="org.codehaus.cargo.container.ContainerException">org.codehaus.cargo.container.ContainerException: Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details.
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:234)
> > at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
> > at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > Caused by: org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
> > at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
> > ... 35 more
> > org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
> > at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
> > at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
> > at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > </error>
>
> Jarek Cecho wrote:
> I'm wondering if you could share the content of /var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log and perhaps even /var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/sqoop.log files Abe?
Attached logs to the Jira ticket. Thanks Jarcec!
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review63142
-----------------------------------------------------------
On Nov. 25, 2014, 2:42 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 2:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml ddcc537
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Jarek Cecho <ja...@apache.org>.
> On Nov. 26, 2014, 9:44 p.m., Abraham Elmahrek wrote:
> > The upgrade tests are failing for me:
> > <error message="Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details." type="org.codehaus.cargo.container.ContainerException">org.codehaus.cargo.container.ContainerException: Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details.
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:234)
> > at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
> > at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > Caused by: org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
> > at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
> > ... 35 more
> > org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
> > at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
> > at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
> > at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > </error>
I'm wondering if you could share the content of /var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log and perhaps even /var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/sqoop.log files Abe?
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review63142
-----------------------------------------------------------
On Nov. 25, 2014, 2:42 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 2:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml ddcc537
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Jarek Cecho <ja...@apache.org>.
> On Nov. 26, 2014, 9:44 p.m., Abraham Elmahrek wrote:
> > The upgrade tests are failing for me:
> > <error message="Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details." type="org.codehaus.cargo.container.ContainerException">org.codehaus.cargo.container.ContainerException: Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details.
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:234)
> > at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
> > at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > Caused by: org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
> > at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
> > ... 35 more
> > org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
> > at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
> > at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
> > at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
> > at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > </error>
>
> Jarek Cecho wrote:
> I'm wondering if you could share the content of /var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log and perhaps even /var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/sqoop.log files Abe?
>
> Abraham Elmahrek wrote:
> Attached logs to the Jira ticket. Thanks Jarcec!
I'm wondering whether this happend only once or whether this is failing consistently for you Abe?
I don't see anything suspicious in the logs. Sqoop 2 App has succesffully booted up per the logs.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review63142
-----------------------------------------------------------
On Nov. 25, 2014, 2:42 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 2:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml ddcc537
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review63142
-----------------------------------------------------------
The upgrade tests are failing for me:
<error message="Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details." type="org.codehaus.cargo.container.ContainerException">org.codehaus.cargo.container.ContainerException: Failed to stop the Tomcat 6.x container. Check the [/var/folders/63/m25ltdlj3dd97m9rkjgv7r600000gs/T//sqoop-cargo-tests/org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest/testPostUpgrade/sqoop-mini-cluster//log/tomcat.log] file containing the container logs for more details.
at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:234)
at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
Caused by: org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
... 35 more
org.codehaus.cargo.container.ContainerException: Server port 8080 did not shutdown within the timeout period [120000]
at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:406)
at org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:315)
at org.codehaus.cargo.container.tomcat.internal.AbstractCatalinaInstalledLocalContainer.waitForCompletion(AbstractCatalinaInstalledLocalContainer.java:206)
at org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:223)
at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
</error>
- Abraham Elmahrek
On Nov. 25, 2014, 2:42 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 2:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml ddcc537
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/
-----------------------------------------------------------
(Updated Nov. 25, 2014, 2:42 a.m.)
Review request for Sqoop.
Changes
-------
I've added more comments explaining what is happening in the test case and what is expected to be done in the child implementations. Thanks for the feedback Veena.
Bugs: SQOOP-1783
https://issues.apache.org/jira/browse/SQOOP-1783
Repository: sqoop-sqoop2
Description
-------
I've added automated test as suggested on the JIRA.
You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
Diffs (updated)
-----
pom.xml ddcc537
test/pom.xml cafa250
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/28373/diff/
Testing
-------
The new test is passing!
Thanks,
Jarek Cecho
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 24, 2014, 3:15 p.m., Veena Basavaraj wrote:
> > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java, line 126
> > <https://reviews.apache.org/r/28373/diff/1/?file=773803#file773803line126>
> >
> > can we have any more assert here to say that the upgrade actually kicked off, some version assertion?
>
> Jarek Cecho wrote:
> I was thinking about that and sadly I currently don't have a good way how to directly detect whether the upgrade happened. We know that it happened only based on the invaritants that are true when you get to the testPostUpgrade() method call. The invariant is that the server is up and running and as a result if we started with older repository version, it had to be upgraded (otherwise the server would fail to start). I recognize that this is not the ideal state, but I don't have anything better available at the moment.
Please add a todo and follow up to do so, it is a good start but still needs some more work to guard against bad code
> On Nov. 24, 2014, 3:15 p.m., Veena Basavaraj wrote:
> > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java, line 46
> > <https://reviews.apache.org/r/28373/diff/1/?file=773803#file773803line46>
> >
> > Will we add a test per repository? in that case please create a ticket for post gres since that is important to have before we call the post gres repo work done.
> >
> >
> > Please rename this class to reflect the below,
> >
> > It is not testing repository schema upgrade, it should be exercising the upgradeConnector nd upgradeDriver code in the Respository.java.
> >
> > So please plug the word data into.
> >
> > Please add these comments explaining what this test case does, so someone new can really understand it
> >
> > DerbyRepoDataUpgrade seems more apt.
>
> Jarek Cecho wrote:
> Yes, I would assume that we will end up having different tests for different repository implementations. Considering that different repository implementations will have different physical structure and requirementes, I believe that it's expected. E.g. I'm assuming that for PostgreSQL we will have to do pg_dump instead of simply targzing the repository structures.
>
> We can't add PostgreSQL upgrade tests, because PostgreSQL haven't been release yet and hence there is nothing to upgrade from. I'll however open subsequent JIRA to not forget on this one. I would also like to see a step in our "How to release wiki page" that will request creation of such JIRAs post every release, so that we will have new tests going forward as well.
>
> This test actually exercise both schema changes and data changes. The idea is to have a snapshot of previous version and verify that I can get from the previous version all the way to current state. And this might (and will) include both structural changes and data changes. Hence If you don't mind, I would like to keep the name as it is.
I actuall said please create a ticket for post gres. Not a test.!! So filing a JIRA as a sub task of the post gres task would be not hard. https://issues.apache.org/jira/browse/SQOOP-1523
If it is testing both, lets make it explicit in a comment and or the name of the class.
Quoting from the kafka guide:
http://kafka.apache.org/coding-guide.html
Clear code is preferable to comments. When possible make your naming so good you don't need comments. When that isn't possible comments should be thought of as mandatory, write them to be read.
> On Nov. 24, 2014, 3:15 p.m., Veena Basavaraj wrote:
> > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java, line 214
> > <https://reviews.apache.org/r/28373/diff/1/?file=773799#file773799line214>
> >
> > rename this to connectorUpgradeProperty ( configuration is overloaded term in sqoop_
> >
> > It is not a connector configuration. I understand why you have named it this way since there are other places, if you can possiblu change all others its good.
>
> Jarek Cecho wrote:
> It seems to me that your comment is not for this line, but for the line above, correct? I'm assuming that you would prefer to rename the newly introduced method getConnectorConfiguration()?
>
> If so then, I would suggest to use connectorManagerConfiguration() as that is more descriptive. Even though that the default method implementation is configuring only the upgrade, other ConnectorManager configuration properties could be specified there.
sure Manager works.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review62894
-----------------------------------------------------------
On Nov. 22, 2014, 6:24 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 6:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml e626c7d
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Jarek Cecho <ja...@apache.org>.
> On Nov. 24, 2014, 11:15 p.m., Veena Basavaraj wrote:
> >
Thank you for your valuable feedback Veena.
> On Nov. 24, 2014, 11:15 p.m., Veena Basavaraj wrote:
> > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java, line 214
> > <https://reviews.apache.org/r/28373/diff/1/?file=773799#file773799line214>
> >
> > rename this to connectorUpgradeProperty ( configuration is overloaded term in sqoop_
> >
> > It is not a connector configuration. I understand why you have named it this way since there are other places, if you can possiblu change all others its good.
It seems to me that your comment is not for this line, but for the line above, correct? I'm assuming that you would prefer to rename the newly introduced method getConnectorConfiguration()?
If so then, I would suggest to use connectorManagerConfiguration() as that is more descriptive. Even though that the default method implementation is configuring only the upgrade, other ConnectorManager configuration properties could be specified there.
> On Nov. 24, 2014, 11:15 p.m., Veena Basavaraj wrote:
> > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java, line 46
> > <https://reviews.apache.org/r/28373/diff/1/?file=773803#file773803line46>
> >
> > Will we add a test per repository? in that case please create a ticket for post gres since that is important to have before we call the post gres repo work done.
> >
> >
> > Please rename this class to reflect the below,
> >
> > It is not testing repository schema upgrade, it should be exercising the upgradeConnector nd upgradeDriver code in the Respository.java.
> >
> > So please plug the word data into.
> >
> > Please add these comments explaining what this test case does, so someone new can really understand it
> >
> > DerbyRepoDataUpgrade seems more apt.
Yes, I would assume that we will end up having different tests for different repository implementations. Considering that different repository implementations will have different physical structure and requirementes, I believe that it's expected. E.g. I'm assuming that for PostgreSQL we will have to do pg_dump instead of simply targzing the repository structures.
We can't add PostgreSQL upgrade tests, because PostgreSQL haven't been release yet and hence there is nothing to upgrade from. I'll however open subsequent JIRA to not forget on this one. I would also like to see a step in our "How to release wiki page" that will request creation of such JIRAs post every release, so that we will have new tests going forward as well.
This test actually exercise both schema changes and data changes. The idea is to have a snapshot of previous version and verify that I can get from the previous version all the way to current state. And this might (and will) include both structural changes and data changes. Hence If you don't mind, I would like to keep the name as it is.
> On Nov. 24, 2014, 11:15 p.m., Veena Basavaraj wrote:
> > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java, line 126
> > <https://reviews.apache.org/r/28373/diff/1/?file=773803#file773803line126>
> >
> > can we have any more assert here to say that the upgrade actually kicked off, some version assertion?
I was thinking about that and sadly I currently don't have a good way how to directly detect whether the upgrade happened. We know that it happened only based on the invaritants that are true when you get to the testPostUpgrade() method call. The invariant is that the server is up and running and as a result if we started with older repository version, it had to be upgraded (otherwise the server would fail to start). I recognize that this is not the ideal state, but I don't have anything better available at the moment.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review62894
-----------------------------------------------------------
On Nov. 23, 2014, 2:24 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2014, 2:24 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml e626c7d
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review62894
-----------------------------------------------------------
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java
<https://reviews.apache.org/r/28373/#comment105030>
rename this to connectorUpgradeProperty ( configuration is overloaded term in sqoop_
It is not a connector configuration. I understand why you have named it this way since there are other places, if you can possiblu change all others its good.
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
<https://reviews.apache.org/r/28373/#comment105031>
Will we add a test per repository? in that case please create a ticket for post gres since that is important to have before we call the post gres repo work done.
Please rename this class to reflect the below,
It is not testing repository schema upgrade, it should be exercising the upgradeConnector nd upgradeDriver code in the Respository.java.
So please plug the word data into.
Please add these comments explaining what this test case does, so someone new can really understand it
DerbyRepoDataUpgrade seems more apt.
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
<https://reviews.apache.org/r/28373/#comment105040>
can we have any more assert here to say that the upgrade actually kicked off, some version assertion?
- Veena Basavaraj
On Nov. 22, 2014, 6:24 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 6:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml e626c7d
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration
upgrade tests
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review62907
-----------------------------------------------------------
Ship it!
Nice feature to have in place to help us move faster wthe releases
- Veena Basavaraj
On Nov. 22, 2014, 6:24 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 6:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1783
> https://issues.apache.org/jira/browse/SQOOP-1783
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added automated test as suggested on the JIRA.
>
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify this patch.
>
>
> Diffs
> -----
>
> pom.xml e626c7d
> test/pom.xml cafa250
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564
> test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java PRE-CREATION
> test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28373/diff/
>
>
> Testing
> -------
>
> The new test is passing!
>
>
> Thanks,
>
> Jarek Cecho
>
>