You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/11/28 06:46:28 UTC
[GitHub] [incubator-brpc] Huixxi opened a new pull request, #2024: add avg latency for prometheus metrics
Huixxi opened a new pull request, #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #2024: add avg latency for prometheus metrics
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328990128
> 这个可能得加在其它地方，这个函数export的是Histogram 类型 https://prometheus.io/docs/concepts/metric_types/#histogram
应该不是Histogram，是Summary类型
https://github.com/apache/incubator-brpc/blob/master/src/brpc/builtin/prometheus_metrics_service.cpp#L159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [brpc] cdjingit merged pull request #2024: add avg latency for prometheus metrics
Posted by "cdjingit (via GitHub)" <gi...@apache.org>.
cdjingit merged PR #2024:
URL: https://github.com/apache/brpc/pull/2024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] add avg latency for prometheus metrics (brpc)
Posted by "Huixxi (via GitHub)" <gi...@apache.org>.
Huixxi commented on PR #2024:
URL: https://github.com/apache/brpc/pull/2024#issuecomment-1512494419
>
这个应该只是打印的时候多了一栏数值，名字是“avg”，具体的值是si->latency_avg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] lorinlee commented on pull request #2024: add avg latency for prometheus metrics
Posted by GitBox <gi...@apache.org>.
lorinlee commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1332207105
summary的quantile写avg是Prometheus支持的吗，这个有相关文档不，我搜了下只找到了quantile里是百分比数字的，还有_sum和_count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #2024: add avg latency for prometheus metrics
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328976572
这个可能得加在其它地方，这个函数export的是Histogram
类型 https://prometheus.io/docs/concepts/metric_types/#histogram
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on pull request #2024: add avg latency for prometheus metrics
Posted by GitBox <gi...@apache.org>.
serverglen commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1331655819
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #2024: add avg latency for prometheus metrics
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1329340427
> > 这个可能得加在其它地方，这个函数export的是Histogram 类型 https://prometheus.io/docs/concepts/metric_types/#histogram
>
> 应该不是Histogram，是Summary类型 https://github.com/apache/incubator-brpc/blob/master/src/brpc/builtin/prometheus_metrics_service.cpp#L159
嗯嗯是Summary。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Huixxi commented on pull request #2024: add avg latency for prometheus metrics
Posted by GitBox <gi...@apache.org>.
Huixxi commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328616643
Fix #2012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org