You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Alan Yu (JIRA)" <ji...@apache.org> on 2007/01/14 16:19:27 UTC

[jira] Created: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
------------------------------------------------------------------

                 Key: HTTPCLIENT-622
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 3.0.1
         Environment: N/A
            Reporter: Alan Yu
            Priority: Critical


Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Re: [jira] Created: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by Michael Becke <mb...@gmail.com>.
I'll take a quick look this afternoon.

Mike

On 1/14/07, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sun, 2007-01-14 at 16:33 +0100, Roland Weber wrote:
> > I don't have a development environment for HttpClient 3.x set up.
> > Getting a JDK 1.2.2 running on a current Linux system is tricky
> > because the old binaries reference an internal symbol of glibc
> > which has since been removed.
> > Mike, Oleg, any chance that one of you could have a look at this
> > issue? Otherwise, I'd try to get the environment up next week-end.
> >
>
> I could take care of this issue if needed.
>
> Mike, would you have time to look into this one?
>
> Oleg
>
> > cheers,
> >   Roland
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Re: [jira] Created: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sun, 2007-01-14 at 16:33 +0100, Roland Weber wrote:
> I don't have a development environment for HttpClient 3.x set up.
> Getting a JDK 1.2.2 running on a current Linux system is tricky
> because the old binaries reference an internal symbol of glibc
> which has since been removed.
> Mike, Oleg, any chance that one of you could have a look at this
> issue? Otherwise, I'd try to get the environment up next week-end.
> 

I could take care of this issue if needed. 

Mike, would you have time to look into this one?

Oleg

> cheers,
>   Roland
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Re: [jira] Created: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by Roland Weber <ht...@dubioso.net>.
Now I do have a development environment for HttpClient.
It was less troublesome than I was afraid of, but the
result is shaky. I got the IBM JDK 1.3.1 running after
patching the startup skript, and the Blackdown 1.2.2
after compiling and pre-loading the internal procedure
that is no longer in glibc.

One problem is that I can compile HttpClient with either
JDK, although I did *not* install JSSE and JCE. That may
have to do with the fact that I'm using the Ant tool that
comes as part of my Linux installation, and that tool
always starts itself with the system JVM which is at
version 5.0.
I noticed strange behavior in HttpComponents too, when
I could compile HttpClient although I didn't have the
commons-logging.jar configured in the build file. Some
things seem to get picked up from the Ant classpath.
Another problem with my HttpClient environment is that
"ant clean compile test" reports errors. Two when using
BD122, between 0 and 3 when using IBM131. If I run the
tests in a separate call:
  ant clean compile
  ant test
then no errors are reported with either JDK.

All in all I believe the environment is just good enough
to create patches, but somebody else will have to test
them in a proper environment. In the long run, I will
have to manually set up two separate Ant installations
that do not use the system JVM, one for HttpComponents
and an older one compatible with Java 1.2.2 for HttpClient.

Write Once, Test Anywhere...

cheers,
  Roland

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Re: [jira] Created: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by Roland Weber <ht...@dubioso.net>.
I don't have a development environment for HttpClient 3.x set up.
Getting a JDK 1.2.2 running on a current Linux system is tricky
because the old binaries reference an internal symbol of glibc
which has since been removed.
Mike, Oleg, any chance that one of you could have a look at this
issue? Otherwise, I'd try to get the environment up next week-end.

cheers,
  Roland

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Michael Becke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464906 ] 

Michael Becke commented on HTTPCLIENT-622:
------------------------------------------

Yep, I think that is the right approach.  I would just add the same to handleLostConnection(). 

Mike

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>            Priority: Critical
>             Fix For: 3.1 Final
>
>         Attachments: mthcm-memoryleak.patch, patch.txt
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Michael Becke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Becke updated HTTPCLIENT-622:
-------------------------------------

    Attachment: mthcm-memoryleak.patch

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>            Priority: Critical
>             Fix For: 3.1 Final
>
>         Attachments: mthcm-memoryleak.patch, patch.txt
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-622:
-----------------------------------------

    Fix Version/s: 3.1 Final

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>            Priority: Critical
>             Fix For: 3.1 Final
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Re: [jira] Commented: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by Roland Weber <ht...@dubioso.net>.
> Ortwin Glück commented on HTTPCLIENT-622:
> -----------------------------------------
> 
> Alan, does the attached one-line patch fix the issue for you?

Tsk tsk tsk. If this was cleanly formatted, it would be two lines...

;-)
  Roland


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464702 ] 

Ortwin Glück commented on HTTPCLIENT-622:
-----------------------------------------

Alan, does the attached one-line patch fix the issue for you?

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>            Priority: Critical
>             Fix For: 3.1 Final
>
>         Attachments: patch.txt
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ortwin Glück updated HTTPCLIENT-622:
------------------------------------

    Attachment: patch.txt

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>            Priority: Critical
>             Fix For: 3.1 Final
>
>         Attachments: patch.txt
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Alan Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464978 ] 

Alan Yu commented on HTTPCLIENT-622:
------------------------------------

Yes, it seems to work.

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>            Priority: Critical
>             Fix For: 3.1 Final
>
>         Attachments: mthcm-memoryleak.patch, patch.txt
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Resolved: (HTTPCLIENT-622) leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts

Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ortwin Glück resolved HTTPCLIENT-622.
-------------------------------------

    Resolution: Fixed
      Assignee: Ortwin Glück

Michael's patch committed.

> leak in MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-622
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-622
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>         Environment: N/A
>            Reporter: Alan Yu
>         Assigned To: Ortwin Glück
>            Priority: Critical
>             Fix For: 3.1 Final
>
>         Attachments: mthcm-memoryleak.patch, patch.txt
>
>
> Once entries are added to MultiThreadedHttpConnectionManager.ConnectionPool.mapHosts, they are never cleaned up unless MultiThreadedHttpConnectionManager is shutdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org