[GitHub] [hive] ramesh0201 commented on a change in pull request #1701: HIVE-24415: HiveSplitGenerator blocks Tez dispatcher

[GitBox <gi...@apache.org>]

ramesh0201 commented on a change in pull request #1701:
URL: https://github.com/apache/hive/pull/1701#discussion_r551546406



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java
##########
@@ -100,37 +99,19 @@
 
   private int sourceInfoCount = 0;
 
-  private final Object endOfEvents = new Object();
-
   private int totalEventCount = 0;
 
-  public DynamicPartitionPruner(InputInitializerContext context, MapWork work, JobConf jobConf) throws
-      SerDeException {
-    this.context = context;
-    this.work = work;
-    this.jobConf = jobConf;
-    synchronized (this) {
-      initialize();
+  public void prune() throws SerDeException, IOException, InterruptedException, HiveException {
+    if (sourcesWaitingForEvents.isEmpty()) {
+      return;
     }
-  }
-
-  public void prune()
-      throws SerDeException, IOException,
-      InterruptedException, HiveException {
 
-    synchronized(sourcesWaitingForEvents) {

Review comment:
       @mustafaiman I could not follow why we removed the synchronized blocks before accessing sourcesWaitingForEvents.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org