You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Siegmund Führinger (JIRA)" <ji...@apache.org> on 2010/06/15 18:33:23 UTC

[jira] Created: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Etag of a view sould only change if a relevant document is changed
------------------------------------------------------------------

                 Key: COUCHDB-799
                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
             Project: CouchDB
          Issue Type: Improvement
          Components: Database Core
    Affects Versions: 0.11
            Reporter: Siegmund Führinger
            Priority: Minor


currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Attachment:     (was: 0001-Fixes-COUCHDB-858.patch)

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

Sorry. The previous patch wouldn't apply to current trunk.

There's no change to the actual code, however.

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Comment: was deleted

(was: Sorry. The previous patch wouldn't apply to current trunk.

There's no change to the actual code, however.)

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921132#action_12921132 ] 

Klaus Trainer commented on COUCHDB-799:
---------------------------------------

Sorry again for that unnecessary noise.

I just messed up my tabs and attached the patch to the wrong issue.

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kocoloski updated COUCHDB-799:
-----------------------------------

    Fix Version/s: 1.1

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>             Fix For: 1.1
>
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Attachment:     (was: COUCHDB-799.patch)

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Attachment: COUCHDB-799.patch

Paul Davis created the initial version of the attached patch and helped me to refine it.

I've fixed an issue with purge, fixed a test case in the design_docs test suite, and added a few test cases to the etags_views test suite.

The history of this patch can be viewed here: http://github.com/KlausTrainer/couchdb/commits/view_etags.

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>         Attachments: COUCHDB-799.patch
>
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Joseph Davis updated COUCHDB-799:
--------------------------------------

    Skill Level: Regular Contributors Level (Easy to Medium)

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>         Attachments: 0001-Don-t-change-a-view-group-s-ETag-as-long-as.patch
>
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Attachment:     (was: 0001-Don-t-change-a-view-group-s-ETag-as-long-as.patch)

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>         Attachments: COUCHDB-799.patch
>
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-799:
----------------------------------

    Attachment: 0001-Don-t-change-a-view-group-s-ETag-as-long-as.patch

With this modification, a view group's ETag (a view group is the set of views contained in a particular design document) won't change as long as updates don't change at least one of the view group's views' indices.

One could still make the ETag calculation more granular, so that it would be calculated on a per-view basis in place of a per-view-group basis. However, it seems that way more intrusive changes would be necessary in order to achieve this.

Please review the attached patch, and tell me what you think about it.

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>         Attachments: 0001-Don-t-change-a-view-group-s-ETag-as-long-as.patch
>
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (COUCHDB-799) Etag of a view sould only change if a relevant document is changed

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Joseph Davis resolved COUCHDB-799.
---------------------------------------

    Resolution: Fixed

Fixed as of 1006345

> Etag of a view sould only change if a relevant document is changed
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-799
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-799
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Siegmund Führinger
>            Priority: Minor
>         Attachments: COUCHDB-799.patch
>
>
> currently the Etag of a view changes, whenever a document is changed. no matter if the document is relevant to the view or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.