You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/05/21 08:23:28 UTC
[GitHub] [iotdb] haimeiguo opened a new pull request #3247: pseudo distributed no logs error
haimeiguo opened a new pull request #3247:
URL: https://github.com/apache/iotdb/pull/3247
logback.xml not added in the conf folder.
now each node's logs are moved to node1/ node2/ node3/ folders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on pull request #3247: pseudo distributed no logs error
Posted by GitBox <gi...@apache.org>.
neuyilan commented on pull request #3247:
URL: https://github.com/apache/iotdb/pull/3247#issuecomment-845783973
> > BTW, does the lockback file[1] is needed? if not, we can delete it.
> > [1] https://github.com/apache/iotdb/blob/master/cluster/src/test/resources/logback.xml
>
> Is it for starting one node by `nohup ./cluster/target/iotdb-cluster-0.13.0-SNAPSHOT/sbin/start-node.sh >/dev/null 2>&1 & `
I think if we only start one node cluster using the command `nohup ./cluster/target/iotdb-cluster-0.13.0-SNAPSHOT/sbin/start-node.sh >/dev/null 2>&1 & `, the logback in the `iotdb-cluster-0.13.0-SNAPSHOT/conf` folder is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou edited a comment on pull request #3247: pseudo distributed no logs error
Posted by GitBox <gi...@apache.org>.
HTHou edited a comment on pull request #3247:
URL: https://github.com/apache/iotdb/pull/3247#issuecomment-845779806
> BTW, does the lockback file[1] is needed? if not, we can delete it.
> [1] https://github.com/apache/iotdb/blob/master/cluster/src/test/resources/logback.xml
Is it for starting one node by `nohup ./cluster/target/iotdb-cluster-0.13.0-SNAPSHOT/sbin/start-node.sh >/dev/null 2>&1 &
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on a change in pull request #3247: pseudo distributed no logs error
Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #3247:
URL: https://github.com/apache/iotdb/pull/3247#discussion_r636756779
##########
File path: cluster/src/test/resources/node2conf/logback.xml
##########
@@ -0,0 +1,282 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<configuration scan="true" scanPeriod="60 seconds">
+ <jmxConfigurator/>
+ <!-- prevent logback from outputting its own status at the start of every log -->
+ <statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender" name="FILEERROR">
+ <file>${IOTDB_HOME}/logs_node2/log_error.log</file>
+ <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
+ <fileNamePattern>${IOTDB_HOME}/logs_node2/log-error-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
+ <maxFileSize>10MB</maxFileSize>
+ <maxHistory>168</maxHistory>
+ <totalSizeCap>512MB</totalSizeCap>
+ </rollingPolicy>
+ <append>true</append>
+ <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+ <pattern>%d [%t] %-5p %C{25}:%L - %m %n</pattern>
+ <charset>utf-8</charset>
+ </encoder>
+ <filter class="ch.qos.logback.classic.filter.LevelFilter">
+ <level>error</level>
+ <onMatch>ACCEPT</onMatch>
+ <onMismatch>DENY</onMismatch>
+ </filter>
+ </appender>
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender" name="FILEWARN">
+ <file>${IOTDB_HOME}/logs_node2/log_warn.log</file>
+ <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
+ <fileNamePattern>${IOTDB_HOME}/logs_node2/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
Review comment:
why use logs_node2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] haimeiguo commented on a change in pull request #3247: pseudo distributed no logs error
Posted by GitBox <gi...@apache.org>.
haimeiguo commented on a change in pull request #3247:
URL: https://github.com/apache/iotdb/pull/3247#discussion_r636758355
##########
File path: cluster/src/test/resources/node2conf/logback.xml
##########
@@ -0,0 +1,282 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<configuration scan="true" scanPeriod="60 seconds">
+ <jmxConfigurator/>
+ <!-- prevent logback from outputting its own status at the start of every log -->
+ <statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender" name="FILEERROR">
+ <file>${IOTDB_HOME}/logs_node2/log_error.log</file>
+ <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
+ <fileNamePattern>${IOTDB_HOME}/logs_node2/log-error-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
+ <maxFileSize>10MB</maxFileSize>
+ <maxHistory>168</maxHistory>
+ <totalSizeCap>512MB</totalSizeCap>
+ </rollingPolicy>
+ <append>true</append>
+ <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+ <pattern>%d [%t] %-5p %C{25}:%L - %m %n</pattern>
+ <charset>utf-8</charset>
+ </encoder>
+ <filter class="ch.qos.logback.classic.filter.LevelFilter">
+ <level>error</level>
+ <onMatch>ACCEPT</onMatch>
+ <onMismatch>DENY</onMismatch>
+ </filter>
+ </appender>
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender" name="FILEWARN">
+ <file>${IOTDB_HOME}/logs_node2/log_warn.log</file>
+ <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
+ <fileNamePattern>${IOTDB_HOME}/logs_node2/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan merged pull request #3247: pseudo distributed no logs error
Posted by GitBox <gi...@apache.org>.
neuyilan merged pull request #3247:
URL: https://github.com/apache/iotdb/pull/3247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org