You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/25 19:48:30 UTC

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1] 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10196

to review the following change.


Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................

java: fix error-prone 'StringSplit' pattern[1]

This should be a non-functional change.

[1] https://github.com/google/error-prone/blob/master/docs/bugpattern/StringSplit.md

Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
4 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10196/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 30 Apr 2018 20:56:00 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 30 Apr 2018 20:00:32 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10196/1/java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java:

http://gerrit.cloudera.org:8080/#/c/10196/1/java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java@146
PS1, Line 146:     String[] components = sigAlg.split("with", 2);
Why is the limit 2 in this case?



-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 14:34:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................

java: fix error-prone 'StringSplit' pattern[1]

This should be a non-functional change.

[1] https://github.com/google/error-prone/blob/master/docs/bugpattern/StringSplit.md

Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Reviewed-on: http://gerrit.cloudera.org:8080/10196
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
5 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Todd Lipcon: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 1:

I see warnings that still exist in ITExportCsv


-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 17:11:10 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 2:

hmm, I bet ITExportCSV didn't get checked by my run because it's in that weird "integration test" set, and I only was running compileTestJava. I guess I have to go figure out how to compile all tests :)


-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 22:19:41 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 1:

Fixed the spot in the integration test build


-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 30 Apr 2018 19:24:06 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 )

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................


Patch Set 2:

I can work on switching over to testng and using test group annotations. In the mean time running `gradle test integrationTest` will work.

Quick gradle tip. If it's unique you can shorten tasks to just their camel case letters. So `gradle iT` will also run the integration tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 23:42:49 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10196

to look at the new patch set (#3).

Change subject: java: fix error-prone 'StringSplit' pattern[1]
......................................................................

java: fix error-prone 'StringSplit' pattern[1]

This should be a non-functional change.

[1] https://github.com/google/error-prone/blob/master/docs/bugpattern/StringSplit.md

Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
5 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10196/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5379ca32be843374fd4a9f7213d096998e436baa
Gerrit-Change-Number: 10196
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>