You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/07 23:17:21 UTC

[GitHub] [pulsar] ebyhr opened a new pull request #7194: Upgrade Presto version to 334

ebyhr opened a new pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194


   Fixes #6605
   
   ### Motivation
   
   
   * Resolve different package between prestosql and prestodb.
   
   ### Modifications
   
   * Upgrade Presto version to 334
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dionjansen edited a comment on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
dionjansen edited a comment on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-640576626






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] findepi commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
findepi commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-640595143






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] ebyhr commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
ebyhr commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-642986685


   @codelipenghui Thanks for your comment. Fixed license check failure. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-642525446


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaoran10 commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-682061124


   @dionjansen Hi, please take a look at this PR #7898, the problem you met was fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dionjansen commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
dionjansen commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-640576626






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dionjansen commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
dionjansen commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-673441779


   @enriched I kind of let this go and postponed using prestosql for now. I was using the 2.6.0 release (I'm not sure this PR was included in that though). This is the Dockerfile I was using to test this out:
   
   ```Dockerfile
   ARG PRESTO_VERSION=336
   FROM prestosql/presto:$PRESTO_VERSION
   ARG PULSAR_MIRROR="https://archive.apache.org/dist/pulsar"
   ARG PULSAR_VERSION="2.6.0"
   ARG PULSAR_BIN="${PULSAR_MIRROR}/pulsar-${PULSAR_VERSION}/apache-pulsar-${PULSAR_VERSION}-bin.tar.gz"
   ARG PULSAR_OFFLOADERS_BIN="${PULSAR_MIRROR}/pulsar-${PULSAR_VERSION}/apache-pulsar-offloaders-${PULSAR_VERSION}-bin.tar.gz"
   ARG PRESTO_HOME="/usr/lib/presto"
   USER root
   RUN yum -y -q update \
       && yum -y -q install wget \
       # Install pulsar presto connector
       && wget --quiet $PULSAR_BIN \
       && tar xzf apache-pulsar-${PULSAR_VERSION}-bin.tar.gz \
       && rm -rf apache-pulsar-${PULSAR_VERSION}-bin.tar.gz \
       && mv apache-pulsar-${PULSAR_VERSION}/lib/presto/plugin/pulsar-presto-connector $PRESTO_HOME/plugin \
       && rm -rf apache-pulsar-${PULSAR_VERSION} \
       # Install offloaders
       && wget --quiet $PULSAR_OFFLOADERS_BIN \
       && tar xzf apache-pulsar-offloaders-${PULSAR_VERSION}-bin.tar.gz \
       && rm -rf apache-pulsar-offloaders-${PULSAR_VERSION}-bin.tar.gz \
       && mv apache-pulsar-offloaders-${PULSAR_VERSION}/offloaders $PRESTO_HOME/offloaders \
       && rm -rf apache-pulsar-offloaders-${PULSAR_VERSION} \
       # Cleanup
       && yum -q clean all
   EXPOSE 8080
   USER presto:presto
   ENV LANG en_US.UTF-8
   CMD ["/usr/lib/presto/bin/run-presto"]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] enriched commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
enriched commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-673161629


   @dionjansen Were you able to resolve the issues with the ClassCastExceptions? I seem to be running into that same issue when trying to add the pulsar-connector to a presto deployment running v332 of prestosql


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dionjansen commented on pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
dionjansen commented on pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194#issuecomment-643236525


   @ebyhr not sure if this is still relevant, but if you'd like me to test this build let me know!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] srkukarni merged pull request #7194: Upgrade Presto version to 332

Posted by GitBox <gi...@apache.org>.
srkukarni merged pull request #7194:
URL: https://github.com/apache/pulsar/pull/7194


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org