You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 06:31:25 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
KarmaGYZ opened a new pull request #12315:
URL: https://github.com/apache/flink/pull/12315
… ResourceInformationReflector#getExternalResources
## What is the purpose of the change
ResourceInformationReflector#getExternalResources should ignore the external resource with a value of 0.
## Brief change log
ResourceInformationReflector#getExternalResources should ignore the external resource with a value of 0.
## Verifying this change
This change added tests and can be verified as follows:
- `ResourceInformationReflectorTest#testGetResourceInformationIgnoreResourceWithZeroValue`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633409833
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9108fb04b2b8cc0eebc941f7e179fcffed296138",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2116",
"triggerID" : "9108fb04b2b8cc0eebc941f7e179fcffed296138",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9108fb04b2b8cc0eebc941f7e179fcffed296138 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2116)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633409833
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9108fb04b2b8cc0eebc941f7e179fcffed296138",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9108fb04b2b8cc0eebc941f7e179fcffed296138",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9108fb04b2b8cc0eebc941f7e179fcffed296138 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #12315:
URL: https://github.com/apache/flink/pull/12315#discussion_r430118921
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/ResourceInformationReflector.java
##########
@@ -151,7 +151,9 @@ void setResourceInformationUnSafe(Object resource, String resourceName, long amo
for (int i = 2; i < externalResourcesInfo.length; i++) {
final String name = (String) resourceInformationGetNameMethod.invoke(externalResourcesInfo[i]);
final long value = (long) resourceInformationGetValueMethod.invoke(externalResourcesInfo[i]);
- externalResources.put(name, value);
+ if (value > 0) {
+ externalResources.put(name, value);
+ }
Review comment:
Yes, you are right.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/ResourceInformationReflector.java
##########
@@ -151,7 +151,9 @@ void setResourceInformationUnSafe(Object resource, String resourceName, long amo
for (int i = 2; i < externalResourcesInfo.length; i++) {
final String name = (String) resourceInformationGetNameMethod.invoke(externalResourcesInfo[i]);
final long value = (long) resourceInformationGetValueMethod.invoke(externalResourcesInfo[i]);
- externalResources.put(name, value);
+ if (value > 0) {
+ externalResources.put(name, value);
+ }
Review comment:
Yes, you are right. I think filtering out entries with a value of 0 would be good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633776377
Thanks a lot for the review @tillrohrmann . I've updated PR and verified it with Yarn 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633403452
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fd2f062214b6bb794f92396a9e388f6f707c296f (Fri Oct 16 10:55:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #12315:
URL: https://github.com/apache/flink/pull/12315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633409833
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633409833
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9108fb04b2b8cc0eebc941f7e179fcffed296138",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2116",
"triggerID" : "9108fb04b2b8cc0eebc941f7e179fcffed296138",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9108fb04b2b8cc0eebc941f7e179fcffed296138 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2116)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12315:
URL: https://github.com/apache/flink/pull/12315#issuecomment-633403452
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9108fb04b2b8cc0eebc941f7e179fcffed296138 (Mon May 25 06:33:47 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17917).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #12315: [FLINK-17917][yarn] Ignore the external resource with a value of 0 in…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #12315:
URL: https://github.com/apache/flink/pull/12315#discussion_r429966710
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/ResourceInformationReflector.java
##########
@@ -151,7 +151,9 @@ void setResourceInformationUnSafe(Object resource, String resourceName, long amo
for (int i = 2; i < externalResourcesInfo.length; i++) {
final String name = (String) resourceInformationGetNameMethod.invoke(externalResourcesInfo[i]);
final long value = (long) resourceInformationGetValueMethod.invoke(externalResourcesInfo[i]);
- externalResources.put(name, value);
+ if (value > 0) {
+ externalResources.put(name, value);
+ }
Review comment:
I think the proper solution is to enforce this invariant in the `InternalContainerResource` constructor (filtering out entries with a value of `0` or to adapt the `equals` method to not check entries with a value of `0`). Otherwise we might run into the situation that sometime in the future when the user can specify the GPU constraints on an operator and he sets it to `0` that the resources won't match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org