You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/03 02:30:36 UTC
[GitHub] [spark] sigmod opened a new pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
sigmod opened a new pull request #32761:
URL: https://github.com/apache/spark/pull/32761
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854904936
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43867/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854910758
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43867/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853625427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139261/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854910758
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43867/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853671338
**[Test build #139277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139277/testReport)** for PR 32761 at commit [`cbf447b`](https://github.com/apache/spark/commit/cbf447b175b68ba8447942a71e22c7ecbbb52402).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854305863
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853589830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43785/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854272782
@hvanhovell @gengliangwang @dbaliafroozeh @maryannxue this PR is read for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853723452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855094586
**[Test build #139357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139357/testReport)** for PR 32761 at commit [`6c9cd28`](https://github.com/apache/spark/commit/6c9cd28ac10163cc4878a13b47e43b6c0af92465).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855094586
**[Test build #139357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139357/testReport)** for PR 32761 at commit [`6c9cd28`](https://github.com/apache/spark/commit/6c9cd28ac10163cc4878a13b47e43b6c0af92465).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853589830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854305863
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853589830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43785/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #32761:
URL: https://github.com/apache/spark/pull/32761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a change in pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
sigmod commented on a change in pull request #32761:
URL: https://github.com/apache/spark/pull/32761#discussion_r645721011
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -549,6 +549,44 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Tre
}
}
+ /**
+ * Returns a copy of this node where `rule` has been recursively applied first to all of its
+ * children and then itself (post-order). When `rule` does not apply to a given node, it is left
+ * unchanged.
+ *
+ * @param cond a Lambda expression to prune tree traversals. If `cond.apply` returns false
+ * on a TreeNode T, skips processing T and its subtree; otherwise, processes
+ * T and its subtree recursively.
+ * @param rule the function use to transform this node and its descendant nodes. The function
+ * takes a tuple as its input, where the first/second field is the before/after
+ * image of applying the rule on the node's children.
+ * @param ruleId is a unique Id for `rule` to prune unnecessary tree traversals. When it is
+ * UnknownRuleId, no pruning happens. Otherwise, if `rule` (with id `ruleId`)
+ * has been marked as in effective on a TreeNode T, skips processing T and its
+ * subtree. Do not pass it if the rule is not purely functional and reads a
+ * varying initial state for different invocations.
+ */
+ def transformUpWithBeforeAndAfterRuleOnChildren(
Review comment:
(1) we probably don't want to expose markRuleAsIneffective to the outside of trees? If it can be used arbitrarily in a rule, the behavior would be harder to reason.
(2) resolveOperatorUpWithPruning can potentially call it. I can do it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32761:
URL: https://github.com/apache/spark/pull/32761#discussion_r645399518
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -549,6 +549,44 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Tre
}
}
+ /**
+ * Returns a copy of this node where `rule` has been recursively applied first to all of its
+ * children and then itself (post-order). When `rule` does not apply to a given node, it is left
+ * unchanged.
+ *
+ * @param cond a Lambda expression to prune tree traversals. If `cond.apply` returns false
+ * on a TreeNode T, skips processing T and its subtree; otherwise, processes
+ * T and its subtree recursively.
+ * @param rule the function use to transform this node and its descendant nodes. The function
+ * takes a tuple as its input, where the first/second field is the before/after
+ * image of applying the rule on the node's children.
+ * @param ruleId is a unique Id for `rule` to prune unnecessary tree traversals. When it is
+ * UnknownRuleId, no pruning happens. Otherwise, if `rule` (with id `ruleId`)
+ * has been marked as in effective on a TreeNode T, skips processing T and its
+ * subtree. Do not pass it if the rule is not purely functional and reads a
+ * varying initial state for different invocations.
+ */
+ def transformUpWithBeforeAndAfterRuleOnChildren(
Review comment:
Since this is only used in `TypeCoercion.scala`, shall we keep it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853723452
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43801/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855161212
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43879/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854215795
**[Test build #139301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139301/testReport)** for PR 32761 at commit [`051d02f`](https://github.com/apache/spark/commit/051d02ff057044f6fa1ceb1b32f59d5408515846).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854272782
@hvanhovell @gengliangwang @dbaliafroozeh @maryannxue this PR is read for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854880295
**[Test build #139345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139345/testReport)** for PR 32761 at commit [`54e38e8`](https://github.com/apache/spark/commit/54e38e81d5e2ead568ad1051900ed8e73367a802).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854240901
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43824/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855004953
**[Test build #139345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139345/testReport)** for PR 32761 at commit [`54e38e8`](https://github.com/apache/spark/commit/54e38e81d5e2ead568ad1051900ed8e73367a802).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855194657
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853525514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a change in pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
sigmod commented on a change in pull request #32761:
URL: https://github.com/apache/spark/pull/32761#discussion_r645720253
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -549,6 +549,44 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Tre
}
}
+ /**
+ * Returns a copy of this node where `rule` has been recursively applied first to all of its
+ * children and then itself (post-order). When `rule` does not apply to a given node, it is left
+ * unchanged.
+ *
+ * @param cond a Lambda expression to prune tree traversals. If `cond.apply` returns false
+ * on a TreeNode T, skips processing T and its subtree; otherwise, processes
+ * T and its subtree recursively.
+ * @param rule the function use to transform this node and its descendant nodes. The function
+ * takes a tuple as its input, where the first/second field is the before/after
+ * image of applying the rule on the node's children.
+ * @param ruleId is a unique Id for `rule` to prune unnecessary tree traversals. When it is
+ * UnknownRuleId, no pruning happens. Otherwise, if `rule` (with id `ruleId`)
+ * has been marked as in effective on a TreeNode T, skips processing T and its
+ * subtree. Do not pass it if the rule is not purely functional and reads a
+ * varying initial state for different invocations.
+ */
+ def transformUpWithBeforeAndAfterRuleOnChildren(
+ cond: BaseType => Boolean, ruleId: RuleId = UnknownRuleId)(
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855005703
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139345/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [WIP][SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853525514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855174261
**[Test build #139357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139357/testReport)** for PR 32761 at commit [`6c9cd28`](https://github.com/apache/spark/commit/6c9cd28ac10163cc4878a13b47e43b6c0af92465).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853550890
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43785/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853783355
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139277/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853586808
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43785/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854215795
**[Test build #139301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139301/testReport)** for PR 32761 at commit [`051d02f`](https://github.com/apache/spark/commit/051d02ff057044f6fa1ceb1b32f59d5408515846).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855174486
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139357/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [WIP][SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853525514
**[Test build #139261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139261/testReport)** for PR 32761 at commit [`a38fd54`](https://github.com/apache/spark/commit/a38fd54e2bc644ced8bd69ec140c3e026264544d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855161207
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43879/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855132263
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43879/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854239352
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43824/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853723397
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43801/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853589830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855005703
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139345/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855161212
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43879/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32761:
URL: https://github.com/apache/spark/pull/32761#discussion_r645747036
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -549,6 +549,44 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Tre
}
}
+ /**
+ * Returns a copy of this node where `rule` has been recursively applied first to all of its
+ * children and then itself (post-order). When `rule` does not apply to a given node, it is left
+ * unchanged.
+ *
+ * @param cond a Lambda expression to prune tree traversals. If `cond.apply` returns false
+ * on a TreeNode T, skips processing T and its subtree; otherwise, processes
+ * T and its subtree recursively.
+ * @param rule the function use to transform this node and its descendant nodes. The function
+ * takes a tuple as its input, where the first/second field is the before/after
+ * image of applying the rule on the node's children.
+ * @param ruleId is a unique Id for `rule` to prune unnecessary tree traversals. When it is
+ * UnknownRuleId, no pruning happens. Otherwise, if `rule` (with id `ruleId`)
+ * has been marked as in effective on a TreeNode T, skips processing T and its
+ * subtree. Do not pass it if the rule is not purely functional and reads a
+ * varying initial state for different invocations.
+ */
+ def transformUpWithBeforeAndAfterRuleOnChildren(
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32761:
URL: https://github.com/apache/spark/pull/32761#discussion_r645398711
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -549,6 +549,44 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Tre
}
}
+ /**
+ * Returns a copy of this node where `rule` has been recursively applied first to all of its
+ * children and then itself (post-order). When `rule` does not apply to a given node, it is left
+ * unchanged.
+ *
+ * @param cond a Lambda expression to prune tree traversals. If `cond.apply` returns false
+ * on a TreeNode T, skips processing T and its subtree; otherwise, processes
+ * T and its subtree recursively.
+ * @param rule the function use to transform this node and its descendant nodes. The function
+ * takes a tuple as its input, where the first/second field is the before/after
+ * image of applying the rule on the node's children.
+ * @param ruleId is a unique Id for `rule` to prune unnecessary tree traversals. When it is
+ * UnknownRuleId, no pruning happens. Otherwise, if `rule` (with id `ruleId`)
+ * has been marked as in effective on a TreeNode T, skips processing T and its
+ * subtree. Do not pass it if the rule is not purely functional and reads a
+ * varying initial state for different invocations.
+ */
+ def transformUpWithBeforeAndAfterRuleOnChildren(
+ cond: BaseType => Boolean, ruleId: RuleId = UnknownRuleId)(
Review comment:
nit: 4 spaces indent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853700895
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43801/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853625427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139261/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853525514
**[Test build #139261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139261/testReport)** for PR 32761 at commit [`a38fd54`](https://github.com/apache/spark/commit/a38fd54e2bc644ced8bd69ec140c3e026264544d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-855174486
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139357/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853761807
**[Test build #139277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139277/testReport)** for PR 32761 at commit [`cbf447b`](https://github.com/apache/spark/commit/cbf447b175b68ba8447942a71e22c7ecbbb52402).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853619415
**[Test build #139261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139261/testReport)** for PR 32761 at commit [`a38fd54`](https://github.com/apache/spark/commit/a38fd54e2bc644ced8bd69ec140c3e026264544d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-853671338
**[Test build #139277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139277/testReport)** for PR 32761 at commit [`cbf447b`](https://github.com/apache/spark/commit/cbf447b175b68ba8447942a71e22c7ecbbb52402).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854880295
**[Test build #139345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139345/testReport)** for PR 32761 at commit [`54e38e8`](https://github.com/apache/spark/commit/54e38e81d5e2ead568ad1051900ed8e73367a802).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854240901
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43824/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32761: [SPARK-35621][SQL] Add rule id pruning to the TypeCoercion rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32761:
URL: https://github.com/apache/spark/pull/32761#issuecomment-854304894
**[Test build #139301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139301/testReport)** for PR 32761 at commit [`051d02f`](https://github.com/apache/spark/commit/051d02ff057044f6fa1ceb1b32f59d5408515846).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org