You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2016/08/30 08:49:20 UTC

[jira] [Commented] (SPARK-17308) Replace all pattern match on boolean value by if/else block.

    [ https://issues.apache.org/jira/browse/SPARK-17308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448472#comment-15448472 ] 

Sean Owen commented on SPARK-17308:
-----------------------------------

Cleaning up stuff like this is a guilty pleasure. I personally support this as if-else is meaningfully more readable, and simpler in byte code for whatever tiny difference that may make. For a critical block, maybe.

> Replace all pattern match on boolean value by if/else block.
> ------------------------------------------------------------
>
>                 Key: SPARK-17308
>                 URL: https://issues.apache.org/jira/browse/SPARK-17308
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 2.0.0
>            Reporter: Shivansh
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org