[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3453: Bind port 8096 to 127.0.0.1

[GitBox <gi...@apache.org>]

GabrielBrascher opened a new pull request #3453: Bind port 8096 to 127.0.0.1
URL: https://github.com/apache/cloudstack/pull/3453
 
 
   ## Description
   <!--- Describe your changes in detail -->
   CloudStack provides CloudStack API Unauthenticated Access through port 8096. It should not be open to the Internet in any case. If this port is not properly blocked by a firewall it could be really serious.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   Fixes: #3450
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   **Using 8080:**
   http://public.ip.address.acs:8080/client/api?command=listClusters&response=json&listAll=true&page=1&pagesize=20&_=1556128046728
   
   ```
   {"listclustersresponse":{"uuidList":[],"errorcode":401,"errortext":"unable to verify user credentials and/or request signature"}}
   ```
   **Using 8096:**
   *Before the fix*
   http://public.ip.address.acs:8096/client/api?command=listClusters&response=json&listAll=true&page=1&pagesize=20&_=1556128046728
   
   ```
   listed all clusters of the zone
   ```
   *With the fix*
   I was able to retrieve the clusters of the zone only when seding the API call via 127.0.0.1 IPv4 address.
   
   ```
   ~$ curl: (7) Failed to connect to public.ip.address.acs port 8096: Connection refused
   [1]   Exit 7                  curl http://public.ip.address.acs:8096/client/api?command=listClusters
   [3]   Done                    listAll=true
   [4]-  Done                    page=1
   [5]+  Done                    pagesize=20
   ```
   ```
   ~$ curl http://localhost:8096/client/api?command=listClusters&response=json&listAll=true&page=1&pagesize=20&_=1556128046728
   [1] 3468
   [2] 3469
   [3] 3470
   [4] 3471
   [5] 3472
   [2]   Done                    response=json
   ```
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services