You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Rakesh R (JIRA)" <ji...@apache.org> on 2014/07/17 20:13:05 UTC

[jira] [Commented] (ZOOKEEPER-1919) Update the C implementation of removeWatches to have it match ZOOKEEPER-1910

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065265#comment-14065265 ] 

Rakesh R commented on ZOOKEEPER-1919:
-------------------------------------

Thanks [~rgs] for the patch. Just few minor comments:

# Instead of "watchers", can we use "watches". Just to sync with the java side API names.
# It would be good to rename union - 'RemoveWatches' to 'WatchesRequest' or a better name, as this union has two types of requests, one for just checking the watch existence and another for remove watch.


> Update the C implementation of removeWatches to have it match ZOOKEEPER-1910
> ----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1919
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1919
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1919.patch
>
>
> See https://issues.apache.org/jira/browse/ZOOKEEPER-1910



--
This message was sent by Atlassian JIRA
(v6.2#6252)