[GitHub] [flink] kl0u commented on a change in pull request #11322: [FLINK-16376][yarn] Use consistent method to get Yarn application dir…

[GitBox <gi...@apache.org>]

kl0u commented on a change in pull request #11322: [FLINK-16376][yarn] Use consistent method to get Yarn application dir…
URL: https://github.com/apache/flink/pull/11322#discussion_r390132205
 
 

 ##########
 File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
 ##########
 @@ -161,10 +161,8 @@ private void testRecursiveUploadForYarn(String scheme, String pathSuffix) throws
 		assumeFalse(fs.exists(basePath));
 
 		try {
-			final Path directory = new Path(basePath, pathSuffix);
-
 			YarnFileStageTest.testCopyFromLocalRecursive(fs.getHadoopFileSystem(),
-				new org.apache.hadoop.fs.Path(directory.toUri()), Path.CUR_DIR, tempFolder, false);
+				Path.CUR_DIR, tempFolder, false);
 
 Review comment:
   @jiasheng55 The `YarnFileStageTestS3ITCase .testRecursiveUploadForYarnS3a ()` seems to be failing on my Travis and the failure seems to be related to this change here. Could you please fix it and then I can merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services