You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/04/01 16:29:25 UTC

[GitHub] [drill] eevanwong commented on pull request #2191: Drill 7882 + Drill 7883 - Fix LGTM Alerts in /common and /contrib

eevanwong commented on pull request #2191:
URL: https://github.com/apache/drill/pull/2191#issuecomment-812024522


   1. Yes there are 17 alerts in total caused by this issue.
   
   ![image](https://user-images.githubusercontent.com/71536798/113321275-6ed9da80-92e1-11eb-8ee6-e8e9bcbbf155.png)
   
   2.  I'm not sure if the null errors are related, the main issue on the alert was that it would point to an NPE if its value didnt change by the time it got to a statement that would use it.
   
    I suppose I could try ensuring var is not null forever; however, it would just be towards another arbitrary value and it would be odd to do it depending on what type of variable it is (e.g File variable I wouldnt know what value to point it towards).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org