You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/10/28 12:05:07 UTC
[GitHub] [incubator-doris] chovy-3012 opened a new pull request #6963: [Doc] Update fe-idea developer guide for latest version
chovy-3012 opened a new pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963
## Proposed changes
Update fe-idea developer guide for latest version
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963#discussion_r738865957
##########
File path: docs/en/developer-guide/fe-idea-dev.md
##########
@@ -43,12 +43,12 @@ If your are only interested in FE module, and for some reason you can't or don't
the minimum tool required for FE module is `thrift`, so you can manually install `thrift` and copy or create a link of
the executable `thrift` command to `./thirdparty/installed/bin`.
-Doris build against `thrift` 0.9.3, and `thrift` 0.9.3.1 should also work well, but the newer version will not.
+Doris build against `thrift` 0.13.0, and `thrift` 0.13.0 should also work well, but the newer version will not.
-If your are using macOS, try `brew install thrift@0.9` and will get `thrift` 0.9.3.1 installed at `/usr/local/opt/thrift@0.9/bin/thrift`,
+If your are using macOS, try `brew install thrift@0.13.0` and will get `thrift` 0.13.0 installed at `/usr/local/opt/thrift@0.13.0/bin/thrift`,
then create a soft link to `./thirdparty/installed/bin/thrift`.
-For Windows users, download `thrift` 0.9.3 from `http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.exe`,
+For Windows users, download `thrift` 0.13.0 from `http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.exe`,
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963#discussion_r738869253
##########
File path: docs/zh-CN/developer-guide/fe-idea-dev.md
##########
@@ -36,10 +36,10 @@ JDK1.8+, IntelliJ IDEA
3. 如果仅进行fe开发而没有编译过thirdparty，则需要安装thrift，并将thrift 复制或者连接到 `thirdparty/installed/bin` 目录下
- 1. 安装 thrift 0.9.3 版本(注意：Doris 基于 thrift 0.9.3 构建, 使用新版本会导致编译不通过)
-
- MacOS: `brew install thrift@0.9`
- Windows: `http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.exe`
+ 安装 thrift 0.13.0 版本(注意：Doris 基于 thrift 0.13.0 构建, 使用新版本会导致编译不通过)
Review comment:
got it !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963#discussion_r738865747
##########
File path: docs/en/developer-guide/fe-idea-dev.md
##########
@@ -43,12 +43,12 @@ If your are only interested in FE module, and for some reason you can't or don't
the minimum tool required for FE module is `thrift`, so you can manually install `thrift` and copy or create a link of
the executable `thrift` command to `./thirdparty/installed/bin`.
-Doris build against `thrift` 0.9.3, and `thrift` 0.9.3.1 should also work well, but the newer version will not.
+Doris build against `thrift` 0.13.0, and `thrift` 0.13.0 should also work well, but the newer version will not.
Review comment:
It should be noted here that 0.15 and later versions need to use thrift 0.13.0, the previous version is still 0.9.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963#issuecomment-954367822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963#discussion_r738866126
##########
File path: docs/zh-CN/developer-guide/fe-idea-dev.md
##########
@@ -36,10 +36,10 @@ JDK1.8+, IntelliJ IDEA
3. 如果仅进行fe开发而没有编译过thirdparty，则需要安装thrift，并将thrift 复制或者连接到 `thirdparty/installed/bin` 目录下
- 1. 安装 thrift 0.9.3 版本(注意：Doris 基于 thrift 0.9.3 构建, 使用新版本会导致编译不通过)
-
- MacOS: `brew install thrift@0.9`
- Windows: `http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.exe`
+ 安装 thrift 0.13.0 版本(注意：Doris 基于 thrift 0.13.0 构建, 使用新版本会导致编译不通过)
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #6963: [Doc] Update fe-idea developer guide for latest version
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #6963:
URL: https://github.com/apache/incubator-doris/pull/6963#discussion_r738866008
##########
File path: docs/en/developer-guide/fe-idea-dev.md
##########
@@ -43,12 +43,12 @@ If your are only interested in FE module, and for some reason you can't or don't
the minimum tool required for FE module is `thrift`, so you can manually install `thrift` and copy or create a link of
the executable `thrift` command to `./thirdparty/installed/bin`.
-Doris build against `thrift` 0.9.3, and `thrift` 0.9.3.1 should also work well, but the newer version will not.
+Doris build against `thrift` 0.13.0, and `thrift` 0.13.0 should also work well, but the newer version will not.
-If your are using macOS, try `brew install thrift@0.9` and will get `thrift` 0.9.3.1 installed at `/usr/local/opt/thrift@0.9/bin/thrift`,
+If your are using macOS, try `brew install thrift@0.13.0` and will get `thrift` 0.13.0 installed at `/usr/local/opt/thrift@0.13.0/bin/thrift`,
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org