You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/11/20 01:39:01 UTC

DO NOT REPLY [Bug 46245] New: Patches for adding AL headers to sources

https://issues.apache.org/bugzilla/show_bug.cgi?id=46245

           Summary: Patches for adding AL headers to sources
           Product: Tomcat 4
           Version: Unknown
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Unknown
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org


Whilst preparing the patches, I noticed two files that don't seem to belong in
SVN:


tc4.1.x/connectors/ajp/proxy/config.m4.patch
servletapi/src/share/dtd/web-app_2_3.dtd.backup

Patches to follow


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #6 from Mark Thomas <ma...@apache.org>  2008-11-19 17:03:50 PST ---
You have attached the connectors patch twice, rather than the container patch.

The spec related DTDs are mostly third party that we need to leave alone.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245


Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22898|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #22898|0                           |1
           is patch|                            |




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245


Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22897|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #22897|0                           |1
           is patch|                            |




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245


Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22896|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #22896|0                           |1
           is patch|                            |




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #11 from Sebb <se...@apache.org>  2008-11-19 17:46:56 PST ---
Created an attachment (id=22901)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22901)
RAT output listing after applying all patches

The RAT listing is attached.

I've excluded quite a few files (pcre, servletapi, VC files).

The main remaining files are .shtml and .jsp, both of which should probably
have AL headers added.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #5 from Sebb <se...@apache.org>  2008-11-19 16:47:16 PST ---
Note that there are still a lot of DTD and JSP files to do.
It was not clear to me if all the DTDs are ASF files or if some are 3rd party.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245


Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Mark Thomas <ma...@apache.org>  2009-02-11 09:04:36 PST ---
Thanks for the patches they have been applied to tc4. Note that the connectors
patches apply to tc5 as well since they share the code.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #3 from Sebb <se...@apache.org>  2008-11-19 16:45:04 PST ---
Created an attachment (id=22897)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22897)
jasper patch


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #4 from Sebb <se...@apache.org>  2008-11-19 16:45:29 PST ---
Created an attachment (id=22898)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22898)
ServletAPI patch


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #7 from Mark Thomas <ma...@apache.org>  2008-11-19 17:05:07 PST ---
In fact for 4.x, anything in servlet API can (should?) be left as is.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #1 from Sebb <se...@apache.org>  2008-11-19 16:44:14 PST ---
Created an attachment (id=22895)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22895)
Patch for containers


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245


Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22895|0                           |1
        is obsolete|                            |




--- Comment #8 from Sebb <se...@apache.org>  2008-11-19 17:26:26 PST ---
Created an attachment (id=22899)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22899)
Container patch


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #2 from Sebb <se...@apache.org>  2008-11-19 16:44:41 PST ---
Created an attachment (id=22896)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22896)
Connectors patch


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #9 from Sebb <se...@apache.org>  2008-11-19 17:28:49 PST ---
(In reply to comment #7)
> In fact for 4.x, anything in servlet API can (should?) be left as is.
> 

Apart from build.xml, which is the only file patched ...


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 46245] Patches for adding AL headers to sources

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46245





--- Comment #10 from Sebb <se...@apache.org>  2008-11-19 17:43:19 PST ---
Created an attachment (id=22900)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22900)
One more container file to patch


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org