You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nuttx.apache.org by Justin Mclean <ju...@classsoftware.com> on 2019/12/22 01:29:45 UTC

Code review tool

Hi,

I just tool a look at the tool Greg uses from review, and notice it runs an exe:

 tools/nxstyle.exe -m 86 $file

So that not going to work for all committers. As I’m not familial with the project, perhaps 
i’m missing something. 

Where is the source for this tool located?

Thanks,
Justin

Re: Code review tool

Posted by Disruptive Solutions <di...@gmail.com>.

Nxstyle is really helpfull...

Verstuurd vanaf mijn iPhone

> Op 22 dec. 2019 om 08:05 heeft Abdelatif Guettouche <ab...@gmail.com> het volgende geschreven:
> 
> Hi Justin,
> 
> Nxstyle is a C file that you can find under tools.
> 
> You can build it under any OS.
> Greg is just using Windows.
> 
>> On Sun, Dec 22, 2019, 03:50 Justin Mclean <ju...@classsoftware.com> wrote:
>> 
>> Hi,
>> 
>> Perhaps someone wants to work on making a portable version of this? It
>> seems it would be using for checking PRs and part of the CI system.
>> 
>> Thanks,
>> Justin

Re: Code review tool

Posted by Abdelatif Guettouche <ab...@gmail.com>.

Hi Justin,

Nxstyle is a C file that you can find under tools.

You can build it under any OS.
Greg is just using Windows.

On Sun, Dec 22, 2019, 03:50 Justin Mclean <ju...@classsoftware.com> wrote:

> Hi,
>
> Perhaps someone wants to work on making a portable version of this? It
> seems it would be using for checking PRs and part of the CI system.
>
> Thanks,
> Justin

Re: Code review tool

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

Perhaps someone wants to work on making a portable version of this? It seems it would be using for checking PRs and part of the CI system.

Thanks,
Justin