You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@commons.apache.org by Sandy McArthur <sa...@apache.org> on 2006/03/21 07:50:00 UTC

[pool] Announcing Release Candidate 1 for Pool 1.3

I've prepared Pool 1.3-rc1 at http://people.apache.org/~sandymac/pool/1.3-rc1/
I'd appreciate it if interested parties reviewed it and tested it with
their setup.

It's been a long time since Pool 1.2 was release and 1.3-rc1 contains
many fixes including ones that substantially change behavior. The most
intrusive fixes are in GenericObjectPool and if there are any
regressions they are most likely to be there.

Pool 1.3-rc1 targets the 1.3 JVM and removes Pool 1.2's the dependency
on Commons Collections so it should run on a stock Java 1.3 JVM.

According to Henri's Commons' Interdependencies[1] Dbcp and
Configuration are the two Commons components that depend on Pool. I
will be testing 1.3-rc1 with Dbcp under heavy load later this week at
work. If someone familiar with Configuration could check it with
1.3-rc1 I would appreciate it.

If after nobody raises any issues on Saturday the 25th I'll start a
vote to make this an official release.

1: http://people.apache.org/~bayard/Commons-Interdependencies.png
--
Sandy McArthur

"He who dares not offend cannot be honest."
- Thomas Paine

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [pool] Announcing Release Candidate 1 for Pool 1.3

Posted by Peter Steijn <ps...@gmail.com>.
seems to work fine on my simple test applications.

Re: [pool] Announcing Release Candidate 1 for Pool 1.3

Posted by Sandy McArthur <sa...@apache.org>.
Thanks for the pointer Niall.

If there are no other issues raised I'll tag and generate 1.3-rc2 this evening.

On 3/22/06, Niall Pemberton <ni...@gmail.com> wrote:
> On 3/22/06, Sandy McArthur <sa...@apache.org> wrote:
>
> > On 3/21/06, Niall Pemberton <ni...@blueyonder.co.uk> wrote:
> > > 3) There was a thread about md5 checksums a while back - some md5
> > > programs require an astix followed by the file name after the checksum:
>
> > I don't get how to express this in maven.
> > I was able to figure out how to make the .md5 extension be lowerclase
> > but I don't know how get it to generate the *filename.
> >
> > Does anyone know the solution off the top of their head?
>
> Validator does this in its maven.xml
>
> http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/validator/trunk/maven.xml
>
> Niall
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>


--
Sandy McArthur

"He who dares not offend cannot be honest."
- Thomas Paine

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [pool] Announcing Release Candidate 1 for Pool 1.3

Posted by Niall Pemberton <ni...@gmail.com>.
On 3/22/06, Sandy McArthur <sa...@apache.org> wrote:

> On 3/21/06, Niall Pemberton <ni...@blueyonder.co.uk> wrote:
> > 3) There was a thread about md5 checksums a while back - some md5
> > programs require an astix followed by the file name after the checksum:

> I don't get how to express this in maven.
> I was able to figure out how to make the .md5 extension be lowerclase
> but I don't know how get it to generate the *filename.
>
> Does anyone know the solution off the top of their head?

Validator does this in its maven.xml

http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/validator/trunk/maven.xml

Niall

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [pool] Announcing Release Candidate 1 for Pool 1.3

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On Tue, 2006-03-21 at 23:55 -0500, Sandy McArthur wrote:
> On 3/21/06, Niall Pemberton <ni...@blueyonder.co.uk> wrote:

<snip>

> > 4) The links on the changelog and file activity report are invalid. This is
> > a bug in the maven plugins, which may be resolved in a later version. One
> > way to get round this is to change to url in the repository element of
> > project.xml to point to the root subversion directory, rather than commons
> > pool (and since your using a custom "cvs-usage" report it shouldn't matter):
> >
> > <repository>
> >    <url>http://svn.apache.org/viewcvs.cgi</url>
> > </repository>
> 
> Setting the url like you suggested fixes the changelog links but
> doesn't help the file activity report. Actually both reports are wrong
> because they don't go back far enough. I think this is related to the
> cvs to svn conversion. How about just removing those two reports until
> the next release?

there are doubts about the accuracy of these reports for dates before
the date of the last import from CVS. so i'm happy to turn them off for
now.

> > 6) Theres a checkstyle config file in pool, but it doesn't appear to be used
> > (and isn't included in the source distro).
> That may be because when you include the checkstyle report it lists
> about 5,000 style errors. Using the checkstyle.xml from IO brings that
> number down to 510, almost all of which are JavaDoc related. When I
> was working on the Pool 1.3 branch I mostly focused on bug fixes and
> didn't try to touch more than was needed. The trunk for pool 2 has
> more extensive clean ups. I suggest the checkstyle be left out until
> the 2.0 release.

+1

> > I ran the tests using maven with JDK 1.3.1_04  and JDK 1.4.2_05 on Windows
> > XP and they passed OK. On W2K the tests passed with JDK 1.4, but failed for
> > JDK 1.3 (TestGenericKeyedObjectPool failed on testEviction2). However my W2K
> > m/c is a bit flakey so I would ignore this unless someone else verifies it.
> This would be a result of the test expecting more determinist behavior
> from the thread scheduler than the JVM guarantees. Odds are if you
> re-run the tests they'll pass most of the time. I've made a good
> effort to make the unit tests in the trunk all be deterministic while
> I haven't put that effort into the 1.3 branch.

a note to that effect might (in more diplomatic language) would make a
good addition to the release notes.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [pool] Announcing Release Candidate 1 for Pool 1.3

Posted by Sandy McArthur <sa...@apache.org>.
On 3/21/06, Niall Pemberton <ni...@blueyonder.co.uk> wrote:
> 1) Its not obvious how to find the release notes for Pool 1.3 - can these be
> included on the navigation menu or somewhere (and a reference in README.txt)
> so that they're easier to find?
Added a link and short blurb in the Releases section of the index page
to the release notes for 1.3.

> 2) build.properties.sample is not being included in the source distro.
Fixed.

> 3) There was a thread about md5 checksums a while back - apparently some md5
> programs require an astix followed by the file name after the checksum:
> http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg67770.html
> http://tinyurl.com/ntjch
I don't get how to express this in maven.
I was able to figure out how to make the .md5 extension be lowerclase
but I don't know how get it to generate the *filename.
http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/pool/branches/1_3_RELEASE_BRANCH/maven.xml?rev=387360&r1=385673&r2=387360&diff_format=h
Does anyone know the solution off the top of their head?

> 4) The links on the changelog and file activity report are invalid. This is
> a bug in the maven plugins, which may be resolved in a later version. One
> way to get round this is to change to url in the repository element of
> project.xml to point to the root subversion directory, rather than commons
> pool (and since your using a custom "cvs-usage" report it shouldn't matter):
>
> <repository>
>    <url>http://svn.apache.org/viewcvs.cgi</url>
> </repository>

Setting the url like you suggested fixes the changelog links but
doesn't help the file activity report. Actually both reports are wrong
because they don't go back far enough. I think this is related to the
cvs to svn conversion. How about just removing those two reports until
the next release?

> 5) I noticed a number of jars I didn't recognise being downloaded:
> msv-20050913.jar, isorelax-20050913.jar,  relaxngDatatype-20050913.jar and
> xsdlib-20050913.jar and just wondered what they were for? Since I can't see
> them referenced anywhere in pool I guess they must be for one of the
> plugins?
Those would be plugin deps auto pulled in by maven. Pool 1.3 doesn't
depend on anything beyond a stock 1.3 jvm.

> 6) Theres a checkstyle config file in pool, but it doesn't appear to be used
> (and isn't included in the source distro).
That may be because when you include the checkstyle report it lists
about 5,000 style errors. Using the checkstyle.xml from IO brings that
number down to 510, almost all of which are JavaDoc related. When I
was working on the Pool 1.3 branch I mostly focused on bug fixes and
didn't try to touch more than was needed. The trunk for pool 2 has
more extensive clean ups. I suggest the checkstyle be left out until
the 2.0 release.

> I ran the tests using maven with JDK 1.3.1_04  and JDK 1.4.2_05 on Windows
> XP and they passed OK. On W2K the tests passed with JDK 1.4, but failed for
> JDK 1.3 (TestGenericKeyedObjectPool failed on testEviction2). However my W2K
> m/c is a bit flakey so I would ignore this unless someone else verifies it.
This would be a result of the test expecting more determinist behavior
from the thread scheduler than the JVM guarantees. Odds are if you
re-run the tests they'll pass most of the time. I've made a good
effort to make the unit tests in the trunk all be deterministic while
I haven't put that effort into the 1.3 branch.

--
Sandy McArthur

"He who dares not offend cannot be honest."
- Thomas Paine

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [pool] Announcing Release Candidate 1 for Pool 1.3

Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
I have a few comments on RC1

1) Its not obvious how to find the release notes for Pool 1.3 - can these be
included on the navigation menu or somewhere (and a reference in README.txt)
so that they're easier to find?

2) build.properties.sample is not being included in the source distro.

3) There was a thread about md5 checksums a while back - apparently some md5
programs require an astix followed by the file name after the checksum:
http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg67770.html
http://tinyurl.com/ntjch

4) The links on the changelog and file activity report are invalid. This is
a bug in the maven plugins, which may be resolved in a later version. One
way to get round this is to change to url in the repository element of
project.xml to point to the root subversion directory, rather than commons
pool (and since your using a custom "cvs-usage" report it shouldn't matter):

<repository>
   <url>http://svn.apache.org/viewcvs.cgi</url>
</repository>

5) I noticed a number of jars I didn't recognise being downloaded:
msv-20050913.jar, isorelax-20050913.jar,  relaxngDatatype-20050913.jar and
xsdlib-20050913.jar and just wondered what they were for? Since I can't see
them referenced anywhere in pool I guess they must be for one of the
plugins?

6) Theres a checkstyle config file in pool, but it doesn't appear to be used
(and isn't included in the source distro).

I ran the tests using maven with JDK 1.3.1_04  and JDK 1.4.2_05 on Windows
XP and they passed OK. On W2K the tests passed with JDK 1.4, but failed for
JDK 1.3 (TestGenericKeyedObjectPool failed on testEviction2). However my W2K
m/c is a bit flakey so I would ignore this unless someone else verifies it.

Niall

----- Original Message ----- 
From: "Sandy McArthur" <sa...@apache.org>
Sent: Tuesday, March 21, 2006 6:50 AM


I've prepared Pool 1.3-rc1 at
http://people.apache.org/~sandymac/pool/1.3-rc1/
I'd appreciate it if interested parties reviewed it and tested it with
their setup.

It's been a long time since Pool 1.2 was release and 1.3-rc1 contains
many fixes including ones that substantially change behavior. The most
intrusive fixes are in GenericObjectPool and if there are any
regressions they are most likely to be there.

Pool 1.3-rc1 targets the 1.3 JVM and removes Pool 1.2's the dependency
on Commons Collections so it should run on a stock Java 1.3 JVM.

According to Henri's Commons' Interdependencies[1] Dbcp and
Configuration are the two Commons components that depend on Pool. I
will be testing 1.3-rc1 with Dbcp under heavy load later this week at
work. If someone familiar with Configuration could check it with
1.3-rc1 I would appreciate it.

If after nobody raises any issues on Saturday the 25th I'll start a
vote to make this an official release.

1: http://people.apache.org/~bayard/Commons-Interdependencies.png
--
Sandy McArthur

"He who dares not offend cannot be honest."
- Thomas Paine

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org