You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Glen Daniels <gl...@thoughtcraft.com> on 2007/03/21 18:41:47 UTC
[axis2] Transport naming refactor
Hi all!
Please note/review this change:
http://svn.apache.org/viewvc?view=rev&rev=520956
In it I refactored the name of transports (both in and out) to be a
String instead of a QName, for simplicity and speed. Let me know if
there are any issues with this. I know I still need to change the docs
to match.
Thanks,
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Deepal Jayasinghe <de...@opensource.lk>.
+1.
Thanks
Deepal
Sanjiva Weerawarana wrote:
> Given the inability to deprecate smoothly I suggest we take the hit
> and put <blink> tags around this change in the release notes.
>
> Maybe we should put a section titled "Backwards Incompatible Changes"
> (and make sure we explain why they are backwards incompatible).
>
> Big +1 for making both the changes proposed!
>
> Sanjiva.
>
> Glen Daniels wrote:
>
>> Hi Asankha:
>>
>> We can certainly add deprecated methods for the setters and the
>> constructors, but not for getName() (since it would only differ by
>> return type). That being the case, I figured just take the hit now
>> rather than only having the set half of the API continue to work.
>>
>> Let me know if you think we should add the deprecated setters, though!
>>
>> --Glen
>>
>> Asankha C. Perera wrote:
>>
>>> Glen
>>>
>>> I agree its good overall, but I am a bit concerned about a public
>>> API change if its without deprecation of the previous methods.
>>> Synapse can upgrade our code - but there may be other projects/code
>>> outside that may get broken. Just a concern..
>>>
>>> asankha
>>>
>>>>> How about
>>>>>
>>>>> public void engageModule(String modName) {
>>>>> engageModule(new QName(modName));
>>>>> }
>>>>
>>>>
>>>> Funny you should ask... How about I just do the same thing with
>>>> Module names (Stringify them) right now and be done with it?
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: axis-dev-help@ws.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-dev-help@ws.apache.org
>>
>>
>
--
Thanks,
Deepal
................................................................
"The highest tower is built one brick at a time"
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
Given the inability to deprecate smoothly I suggest we take the hit and
put <blink> tags around this change in the release notes.
Maybe we should put a section titled "Backwards Incompatible Changes" (and
make sure we explain why they are backwards incompatible).
Big +1 for making both the changes proposed!
Sanjiva.
Glen Daniels wrote:
> Hi Asankha:
>
> We can certainly add deprecated methods for the setters and the
> constructors, but not for getName() (since it would only differ by
> return type). That being the case, I figured just take the hit now
> rather than only having the set half of the API continue to work.
>
> Let me know if you think we should add the deprecated setters, though!
>
> --Glen
>
> Asankha C. Perera wrote:
>> Glen
>>
>> I agree its good overall, but I am a bit concerned about a public API
>> change if its without deprecation of the previous methods. Synapse can
>> upgrade our code - but there may be other projects/code outside that
>> may get broken. Just a concern..
>>
>> asankha
>>
>>>> How about
>>>>
>>>> public void engageModule(String modName) {
>>>> engageModule(new QName(modName));
>>>> }
>>>
>>> Funny you should ask... How about I just do the same thing with
>>> Module names (Stringify them) right now and be done with it?
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-dev-help@ws.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hi Deepal!
Deepal Jayasinghe wrote:
>> OK, here's what I'm planning to do as a compromise position here. Let
>> me know what you think.
>>
>> For now, I'm going to make the Module changes, and put the deprecated
>> setters in for both Transports and Modules, but COMMENTED OUT.
>
> I think we do not need to mark the method as deprecated , just rename
> the method signature.
We should deprecate them because they're going to go away. I see no
particular need for a setter which just strips the namespace part off a
QName - you can easily do that yourself. Are you saying you think we
should keep them?
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Deepal Jayasinghe <de...@opensource.lk>.
Hi Glen;
> OK, here's what I'm planning to do as a compromise position here. Let
> me know what you think.
>
> For now, I'm going to make the Module changes, and put the deprecated
> setters in for both Transports and Modules, but COMMENTED OUT.
I think we do not need to mark the method as deprecated , just rename
the method signature.
Thanks
Deepal
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
+1.
Sanjiva.
Glen Daniels wrote:
> OK, here's what I'm planning to do as a compromise position here. Let
> me know what you think.
>
> For now, I'm going to make the Module changes, and put the deprecated
> setters in for both Transports and Modules, but COMMENTED OUT. This
> will essentially force us within the Apache WS community to fix
> references ASAP, and make it very clear where they are (due to breaks as
> opposed to ignorable warnings).
>
> Before we release, we'll uncomment the deprecated setters so that our
> users get maximum backwards-compatibility. Then we can remove them for
> good next release.
>
> Sound like a plan?
>
> --Glen
>
> Paul Fremantle wrote:
>> I'm +1 on this. Do the deprecated setters and most importantly the
>> deprecated engageModule(QName).
>>
>> Paul
>>
>> On 3/21/07, Glen Daniels <gl...@thoughtcraft.com> wrote:
>>> Hi Asankha:
>>>
>>> We can certainly add deprecated methods for the setters and the
>>> constructors, but not for getName() (since it would only differ by
>>> return type). That being the case, I figured just take the hit now
>>> rather than only having the set half of the API continue to work.
>>>
>>> Let me know if you think we should add the deprecated setters, though!
>>>
>>> --Glen
>>>
>>> Asankha C. Perera wrote:
>>> > Glen
>>> >
>>> > I agree its good overall, but I am a bit concerned about a public API
>>> > change if its without deprecation of the previous methods. Synapse can
>>> > upgrade our code - but there may be other projects/code outside
>>> that may
>>> > get broken. Just a concern..
>>> >
>>> > asankha
>>> >
>>> >>> How about
>>> >>>
>>> >>> public void engageModule(String modName) {
>>> >>> engageModule(new QName(modName));
>>> >>> }
>>> >>
>>> >> Funny you should ask... How about I just do the same thing with
>>> Module
>>> >> names (Stringify them) right now and be done with it?
>>> >
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>>> > For additional commands, e-mail: axis-dev-help@ws.apache.org
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: axis-dev-help@ws.apache.org
>>>
>>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Glen Daniels <gl...@thoughtcraft.com>.
OK, here's what I'm planning to do as a compromise position here. Let
me know what you think.
For now, I'm going to make the Module changes, and put the deprecated
setters in for both Transports and Modules, but COMMENTED OUT. This
will essentially force us within the Apache WS community to fix
references ASAP, and make it very clear where they are (due to breaks as
opposed to ignorable warnings).
Before we release, we'll uncomment the deprecated setters so that our
users get maximum backwards-compatibility. Then we can remove them for
good next release.
Sound like a plan?
--Glen
Paul Fremantle wrote:
> I'm +1 on this. Do the deprecated setters and most importantly the
> deprecated engageModule(QName).
>
> Paul
>
> On 3/21/07, Glen Daniels <gl...@thoughtcraft.com> wrote:
>> Hi Asankha:
>>
>> We can certainly add deprecated methods for the setters and the
>> constructors, but not for getName() (since it would only differ by
>> return type). That being the case, I figured just take the hit now
>> rather than only having the set half of the API continue to work.
>>
>> Let me know if you think we should add the deprecated setters, though!
>>
>> --Glen
>>
>> Asankha C. Perera wrote:
>> > Glen
>> >
>> > I agree its good overall, but I am a bit concerned about a public API
>> > change if its without deprecation of the previous methods. Synapse can
>> > upgrade our code - but there may be other projects/code outside that
>> may
>> > get broken. Just a concern..
>> >
>> > asankha
>> >
>> >>> How about
>> >>>
>> >>> public void engageModule(String modName) {
>> >>> engageModule(new QName(modName));
>> >>> }
>> >>
>> >> Funny you should ask... How about I just do the same thing with Module
>> >> names (Stringify them) right now and be done with it?
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> > For additional commands, e-mail: axis-dev-help@ws.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-dev-help@ws.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Paul Fremantle <pz...@gmail.com>.
I'm +1 on this. Do the deprecated setters and most importantly the
deprecated engageModule(QName).
Paul
On 3/21/07, Glen Daniels <gl...@thoughtcraft.com> wrote:
> Hi Asankha:
>
> We can certainly add deprecated methods for the setters and the
> constructors, but not for getName() (since it would only differ by
> return type). That being the case, I figured just take the hit now
> rather than only having the set half of the API continue to work.
>
> Let me know if you think we should add the deprecated setters, though!
>
> --Glen
>
> Asankha C. Perera wrote:
> > Glen
> >
> > I agree its good overall, but I am a bit concerned about a public API
> > change if its without deprecation of the previous methods. Synapse can
> > upgrade our code - but there may be other projects/code outside that may
> > get broken. Just a concern..
> >
> > asankha
> >
> >>> How about
> >>>
> >>> public void engageModule(String modName) {
> >>> engageModule(new QName(modName));
> >>> }
> >>
> >> Funny you should ask... How about I just do the same thing with Module
> >> names (Stringify them) right now and be done with it?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-dev-help@ws.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Paul Fremantle
VP/Technology, WSO2 and OASIS WS-RX TC Co-chair
http://bloglines.com/blog/paulfremantle
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hi Asankha:
We can certainly add deprecated methods for the setters and the
constructors, but not for getName() (since it would only differ by
return type). That being the case, I figured just take the hit now
rather than only having the set half of the API continue to work.
Let me know if you think we should add the deprecated setters, though!
--Glen
Asankha C. Perera wrote:
> Glen
>
> I agree its good overall, but I am a bit concerned about a public API
> change if its without deprecation of the previous methods. Synapse can
> upgrade our code - but there may be other projects/code outside that may
> get broken. Just a concern..
>
> asankha
>
>>> How about
>>>
>>> public void engageModule(String modName) {
>>> engageModule(new QName(modName));
>>> }
>>
>> Funny you should ask... How about I just do the same thing with Module
>> names (Stringify them) right now and be done with it?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by "Asankha C. Perera" <as...@wso2.com>.
Glen
I agree its good overall, but I am a bit concerned about a public API
change if its without deprecation of the previous methods. Synapse can
upgrade our code - but there may be other projects/code outside that may
get broken. Just a concern..
asankha
>> How about
>>
>> public void engageModule(String modName) {
>> engageModule(new QName(modName));
>> }
>
> Funny you should ask... How about I just do the same thing with Module
> names (Stringify them) right now and be done with it?
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hi Paul!
> Yay!
:)
> How about
>
> public void engageModule(String modName) {
> engageModule(new QName(modName));
> }
Funny you should ask... How about I just do the same thing with Module
names (Stringify them) right now and be done with it?
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [axis2] Transport naming refactor
Posted by Paul Fremantle <pz...@gmail.com>.
Yay!
How about
public void engageModule(String modName) {
engageModule(new QName(modName));
}
Paul
On 3/21/07, Glen Daniels <gl...@thoughtcraft.com> wrote:
> Hi all!
>
> Please note/review this change:
>
> http://svn.apache.org/viewvc?view=rev&rev=520956
>
> In it I refactored the name of transports (both in and out) to be a
> String instead of a QName, for simplicity and speed. Let me know if
> there are any issues with this. I know I still need to change the docs
> to match.
>
> Thanks,
> --Glen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Paul Fremantle
VP/Technology, WSO2 and OASIS WS-RX TC Co-chair
http://bloglines.com/blog/paulfremantle
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org