You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/21 20:03:45 UTC
[GitHub] [tvm] masahi opened a new pull request #8109: [Target] Add a default warp size 1 for vulkan and opencl
masahi opened a new pull request #8109:
URL: https://github.com/apache/tvm/pull/8109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8109: [Target] Add a default warp size 1 for vulkan and opencl
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8109:
URL: https://github.com/apache/tvm/pull/8109#issuecomment-846277348
Looks good to me, and I agree on using 1 as the default `thread_warp_size`. Both the [`VkPhysicalDeviceSubgroupProperties`](https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkPhysicalDeviceSubgroupProperties.html) and the [`VkPhysicalDeviceSubgroupSizeControlPropertiesEXT`](https://khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkPhysicalDeviceSubgroupSizeControlPropertiesEXT.html) documentation give a minimum subgroup size of 1, so the spec doesn't give us any further guarantees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #8109: [Target] Add a default warp size 1 for vulkan and opencl
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #8109:
URL: https://github.com/apache/tvm/pull/8109#issuecomment-846260722
Thanks for the quick reply. In that case, `thread_warp_size` of 1 should be a good default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #8109: [Target] Add a default warp size 1 for vulkan and opencl
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #8109:
URL: https://github.com/apache/tvm/pull/8109#issuecomment-846251949
The code looks good to me. May I know why the default `thread_warp_size` is 1 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #8109: [Target] Add a default warp size 1 for vulkan and opencl
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #8109:
URL: https://github.com/apache/tvm/pull/8109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8109: [Target] Add a default warp size 1 for vulkan and opencl
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8109:
URL: https://github.com/apache/tvm/pull/8109#issuecomment-846259999
Because it need to support ALL vulkan or opencl devices. 1 is the only value that could work, but it is useless in terms of performance. It's only there so that compiling models on vulkan wouldn't break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org